Closed Bug 1573570 Opened 3 years ago Closed 3 years ago
Include prebuilt OTR libraries in Thunderbird CI builds
This is the Taskcluster merge_loader. Using the merge loader, tasks within a single kind can come from both M-C and C-C trees. The implementation calls the reference_loader function followed by the transform_loader function, merging the two loaders into one. As noted in the commit message, there are issues when the kind has dependencies. I believe it is only a problem when a task within a kind depends on another task of the same kind. This happens quite a bit with toolchains for instance. The initial use case for this is for some fetch tasks, and there are no dependency issues there.
Task configuration that grabs Kai's prebuilt OTR libraries from his server so they can be included in Taskcluster builds. Uses merge_loader. Currently broken.
Comment on attachment 9085304 [details] [diff] [review] Patch 2 - otr_fetches.patch Nit in commit message: This just sets up the Taskcluster pieec.
Latest update of patch. This is working now.
Comment on attachment 9085303 [details] [diff] [review] Patch 1 - merge_loader.patch No changes have been made to this patch since initial submission. It's been working well.
Comment on attachment 9089913 [details] [diff] [review] Patch 2 - otr_fetches.patch This are the fetch tasks that will retrieve Kai's prebuilt libraries and modifications to the build configurations so they depend on those files. Only submitting for review, waiting for a green light to actually land these.
Attachment #9089913 - Flags: review?(geoff)
If you have suggestions to improve package-manifest.in, let me know. Hopefully some creative Makefile flags can improve the situation in the next iteration.
Summary: Create new Taskcluster loader to look for definitions in comm- and mozilla- in a single kind → Include prebuilt OTR libraries in Thunderbird CI builds
Attachment #9090119 - Flags: review?(geoff)
Attachment #9085303 - Flags: review?(geoff) → review+
Attachment #9089913 - Flags: review?(geoff) → review+
Comment on attachment 9090119 [details] [diff] [review] Patch 3 - otr_packaging.patch Review of attachment 9090119 [details] [diff] [review]: ----------------------------------------------------------------- This seems fine. Just for the record, this is only a review of the code. I'm not making a comment on whether or not it should be done this way (or at all) – those decisions are for other people. ::: third_party/Makefile.in @@ +15,5 @@ > + libgpg-error-0.dll \ > + libotr-5.dll \ > + libssp-0.dll > +else > +ifeq (Darwin,$(OS_ARCH)) I'm no expert on Makefiles, so ignore me if I'm wrong, but I think if this was "else ifeq …" you'd only need one endif. @@ +24,5 @@ > +else > +OTR_LIBS = \ > + libgcrypt.so.20 \ > + libgpg-error.so.0 \ > + libotr.so.5 Indentation.
Attachment #9090119 - Flags: review?(geoff) → review+
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.