Closed Bug 1592162 Opened 1 year ago Closed 1 year ago

Split comm_taskgraph loaders and transforms into separate packages

Categories

(Thunderbird :: Build Config, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 72.0

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(2 files, 3 obsolete files)

This is to facilitate work going on in a few different bugs.

comm/taskcluster/comm_taskgraph/init.py is a collection of mostly transforms functions. Thunderbird's build needs are changing and this file has grown some as a result. Splitting transforms and loaders out into separate packages will mirror the Firefox structure and keep various WIP patches from colliding.

Attached patch comm_taskgraph_splitup.patch (obsolete) — Splinter Review
Semi-WIP.
Assignee: nobody → rob
Status: NEW → ASSIGNED
Blocks: 1550611

Did you want this reviewed? You said it was waiting for review but it isn't and comment 1 suggests it's unfinished.

Attached patch comm_taskgraph_splitup.patch (obsolete) — Splinter Review
This is ready.
Attachment #9106346 - Flags: review?(geoff)
Attachment #9104823 - Attachment is obsolete: true
This is semi-beta, but because it's only been verified to work on fetch
tasks.
Toolchains in particular don't really work, but I those issues are likely
to be solved elsewhere.
source-tests come to mind as a possible consumer of this loader.
Attachment #9106349 - Flags: review?(geoff)
Comment on attachment 9106346 [details] [diff] [review]
comm_taskgraph_splitup.patch

Review of attachment 9106346 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/comm_taskgraph/transforms/addon.py
@@ +54,5 @@
> +            if "ja-JP-mac" in chunked_locales:
> +                label = "unsigned-repack-mac"
> +                job["dependencies"][
> +                    label] = "nightly-l10n-macosx64-shippable-%d/opt" % \
> +                             this_chunk

This is some, uhh, "pretty" wrapping. Let's go back to 99 characters.
Attachment #9106346 - Flags: review?(geoff) → review+
Attachment #9106349 - Flags: review?(geoff) → review+
Attachment #9106346 - Attachment is obsolete: true
Using the correct repo... addresses the formatting in comment 5.
Attachment #9106393 - Attachment is obsolete: true

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e1879be2884c
Add merge loader. r=darktrojan
https://hg.mozilla.org/comm-central/rev/fee24a698db4
Split comm_taskgraph functions into loader and transform packages. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 72.0
You need to log in before you can comment on or make changes to this bug.