1573631 - [css-text-decor-4] Let `text-decoration-skip-ink`, `text-decoration-thickness`, and `text-underline-offset` ride the trains to release

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement, P1)

Description

[Daniel Holbert [:dholbert]]

I'm filing this bug on letting text-decoration-skip-ink ride the trains to release (i.e. setting layout.css.text-decoration-skip-ink.enabled to true unconditionally)

For any issues that definitely need to be fixed before we ship, we should mark the issue as blocking this bug.

Note also that we'll be enabling the pref in Nightly (at least) very soon in bug 1572800.

Comment 1

[Daniel Holbert [:dholbert]]

Per bug 1572800 comment 3, we should probably enable all three new text-decoration properties as a bundle.
--> updating summary & dependencies. (And adding bug 1574222 as dependency since we need to fix that before letting text-decoration-thickness hit release.)

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Looks like this is something you're aiming to ship in 70 - can you suggest a release note if you think one is a good idea?

Comment 3

[Daniel Holbert [:dholbert]]

Thanks! Yes, a release note would be a good idea.

Something like the following would be good:

• Firefox now supports the CSS properties "text-decoration-thickness" and "text-underline-offset", which let web developers control the position and size of text decoration lines.
• Firefox now supports the CSS property "text-decoration-skip-ink", which (by default) makes underlines and overlines skip over any text that they intersect, to improve readability.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: Bug 1573631: Let "text-decoration-skip-ink", "text-decoration-thickness", and "text-underline-offset" ride the trains to release. r?jfkthame

Comment 5

[Daniel Holbert [:dholbert]]

[Tracking Requested - why for this release]:
Planning on shipping these features as part of Firefox 70 (pending bug 1574222 making it there - that's the last minor defect that we're aware of).
They're already enabled through "early beta" (so 70beta users already have these , and this bug here is aimed at removing that restriction.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking since we aim to ship this in 70.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f08b7d13ccc
Let "text-decoration-skip-ink", "text-decoration-thickness", and "text-underline-offset" ride the trains to release. r=jfkthame

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3f08b7d13ccc

Comment 10

[Daniel Holbert [:dholbert]]

I posted an intent-to-ship to dev-platform: https://groups.google.com/forum/#!topic/mozilla.dev.platform/2h1Nlx4_WIU

Toggling needinfo to remind me to do an uplift request.

Comment 11

[Daniel Holbert [:dholbert]]

Comment on attachment 9091533 [details]
Bug 1573631: Let "text-decoration-skip-ink", "text-decoration-thickness", and "text-underline-offset" ride the trains to release. r?jfkthame

Beta/Release Uplift Approval Request

• User impact if declined: These new text decoration features would automatically become disabled after we exit the "early beta" period (and they wouldn't ship until Firefox 71), even though we think they're ready now.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1574222 (which has its own beta-uplift request)
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch just touches pref guards, so that the configuration that we've already been testing in "early beta" (these features being enabled) will persist through the rest of the beta cycle and into release.
• String changes made/needed: None.

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9091533 [details]
Bug 1573631: Let "text-decoration-skip-ink", "text-decoration-thickness", and "text-underline-offset" ride the trains to release. r?jfkthame

Keep new css properties enabled past early beta.

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/304917618650

Comment 14

[Chris Mills [:cmills]]

I've done a tonne of documentation work to get these new properties adequately represented on MDN; see https://github.com/mdn/sprints/issues/2104#issuecomment-531801054 for the details of what I did. I'm really excited to see these supported by default!

A review would be much appreciated when you have some spare time. Thanks!

Comment 15

[Daniel Holbert [:dholbert]]

(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #14)

I've done a tonne of documentation work [...]
A review would be much appreciated when you have some spare time. Thanks!

Thanks! I'll take a look later today.

princess.shosho6030 added flags: needinfo?([e-mail])

princess.shosho6030, it looks like you're a new user and you perhaps toggled a needinfo for yourself by mistake. Please don't play around with flags on bugs that you're not working on; it creates spam/cleanup-work for other people.

Comment 17

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #15)

(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #14)

I've done a tonne of documentation work [...]
A review would be much appreciated when you have some spare time. Thanks!

Thanks! I'll take a look later today.

(The documentation is great; I reviewed & gave feedback off-bug. Thanks, Chris!)

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Noted as "Readability is now greatly improved on under- or overlined texts, including links. The lines will now be interrupted instead of crossing over a glyph."