Don't send matrices to to the main thread when Fission disabled
Categories
(Core :: Panning and Zooming, defect, P1)
Tracking
()
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 obsolete file)
To hide bug 1565525 from non-Fission users, re-insert a pref check, but for fission.autostart here:
https://hg.mozilla.org/mozilla-central/rev/91d0c9066fd1#l5.55
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
Sigh. It looks a lot like this patch makes bug 1571254 perma-orange. I wonder if there's a problem with cross-process pref syncing.
|
|
Assignee | |
Comment 5•5 years ago
|
||
Times out even with the compositor in the chrome process...
|
|
Assignee | |
Comment 6•5 years ago
|
||
I don't see the test flipping the pref.
|
|
Assignee | |
Comment 7•5 years ago
|
||
The test passes in the M-fis set.
|
|
Assignee | |
Comment 8•5 years ago
|
||
|
||
Comment 9•5 years ago
|
||
Please make sure this change doesn't regress bug 1548687 in the fission-disabled case. I suspect it will since we use those matrices outside of fission.
|
|
||
Comment 10•5 years ago
•
|
||
Or to put it differently, disabling this test if the pref is not set means we lose meaningful test coverage, and I would probably r-minus it (if I were around and had time to fix this properly)
|
|
||
Comment 11•5 years ago
|
||
I left a comment on bug 1565525 with a suggestions for other possible fixes that I believe would work. I don't think I'll be able to attempt them myself in the near future though.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) (away until Feb-2020) from comment #9)
Please make sure this change doesn't regress bug 1548687 in the fission-disabled case. I suspect it will since we use those matrices outside of fission.
To clarify a bit more here, the way to ensure this doesn't regress bug 1548687 would be to (a) apply your patch, (b) remove the workaround (this line), and then (c) follow the STR in bug 1548687 comment 0 from step 2 onwards.
|
|
||
Comment 12•5 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) (away until Feb-2020) from comment #9)
we use those matrices outside of fission.
Ah, I didn't realize that.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) (away until Feb-2020) from comment #11)
I left a comment on bug 1565525 with a suggestions for other possible fixes that I believe would work. I don't think I'll be able to attempt them myself in the near future though.
I can give your suggestion a try.
(b) remove the workaround (this line)
Do you know why that workaround is still in-tree?
|
|
||
Comment 13•5 years ago
|
||
I requested removal of the workaround here and bug 1565235 was filed for it but I guess nobody has gotten around to writing the patch. I don't think there's anything actually blocking it.
|
|
Assignee | |
Comment 14•5 years ago
|
||
Thanks. With the patches over at bug 1565525, this bug is obsolete.
|
||
Updated•5 years ago
|
Description
•