1574469 - nsCookiePermission PermissionManager calls should use principals

Status: RESOLVED FIXED

(Core :: Networking: Cookies, task, P3)

Description

[Emma Zühlcke [:emz]]

We would like to remove permission manager calls with nsIURI in bug 1402957.

Affected PermissionManager usages: https://searchfox.org/mozilla-central/rev/3a61fb322f74a0396878468e50e4f4e97e369825/netwerk/cookie/nsCookiePermission.cpp#77,93

Comment 1

[Honza Bambas (:mayhemer)]

Reflecting P of 1402957.

Comment 2

[Emma Zühlcke [:emz]]

After a discussion with :johannh and :ehsan we've decided to create a "legacy" permission manager method (not exposed via IDL) to test cookie permission via URI + origin parameters. This prevents us from having to create a new principal on every cookie service call.
We opted for a similar approach in Bug 1574473.

Comment 3

[Emma Zühlcke [:emz]]

Attachment: Bug 1574469 - Implemented nsPermissionManager::LegacyTestPermissionFromURI for nsIURI queries with origin attributes. r=ehsan,johannh

Comment 4

[Emma Zühlcke [:emz]]

Attachment: Bug 1574469 - Removed block param from nsICookieManager::Remove. r=ehsan,johannh

Depends on D45847

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8945e9f62d6e
Implemented nsPermissionManager::LegacyTestPermissionFromURI for nsIURI queries with origin attributes. r=Ehsan

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb1b6afa9f33
Removed block param from nsICookieManager::Remove. r=Ehsan

Comment 7

[Oana Pop-Rus]

Backed out for multiple failures in nsICookieManager.remove

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=cb1b6afa9f3335d1c2b7fd80cbbedb9ec2d82918&selectedJob=268123549

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=268123549&repo=autoland&lineNumber=28154

Backout: https://hg.mozilla.org/integration/autoland/rev/4c4c25595fe8e9b234e9731128abbd4e324749d8

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/8945e9f62d6e

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e70e0a2952b6
Removed block param from nsICookieManager::Remove. r=Ehsan

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e70e0a2952b6