Closed Bug 1574750 Opened 4 months ago Closed 4 months ago

Remove support for MathML length values thinmathspace, mediummathspace, thickmathspace, etc

Categories

(Core :: MathML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: fredw, Assigned: fredw)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file)

MathML3 defines the following values: https://www.w3.org/TR/MathML3/chapter2.html#type.namedspace

But they are equivalent to em values. The MathML CG agreed to removed them from Core: https://github.com/mathml-refresh/mathml/issues/75#issuecomment-487757558

I think we will need to proceed carefully with these, as we know they are being used https://github.com/mathml-refresh/mathml/issues/55

Blocks: 1574751
Keywords: site-compat

See https://github.com/mathml-refresh/mathml/issues/75
and https://groups.google.com/forum/#!topic/mozilla.dev.platform/yEMdIOo4i-0

This commit introduces a new preference option
mathml.mathspace_names.disabled to disable *mathspace names for MathML lengths.
For now, these are only disabled in Nightly builds.

  • test_bug553917.html is updated to check that these values now cause an
    error message to be logged into the console when mathsize names are used
    and the feature disabled.
  • mathml-negativespace-ref.html and positive-namedspace.html verify support for
    mathspace names, so force running them with the support enabled.
  • The reference files for mo-lspace-rspace-2.html, mo-lspace-rspace-3.html,
    mo-lspace-rspace.html, op-dict-8.html and op-dict-9.html use explicit
    lspace/rspace attributes corresponding to the one read from the operator
    dictionary. Instead of running them with mathspace names enabled, use the
    equivalent em values from core
    https://mathml-refresh.github.io/mathml-core/#operator-dictionary
    See https://github.com/mathml-refresh/mathml/issues/75#issuecomment-523016332
  • Force WPT tests
    mathml/presentation-markup/fractions/frac-linethickness-002.html and
    mathml/relations/css-styling/lengths-2.html to be run with the features
    disabled and remove corresponding failure expectation.
Depends on: 1575542

Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc9ada7ccc21
Remove support for MathML length values thinmathspace, mediummathspace, thickmathspace, etc. r=emilio

Keywords: checkin-needed

For the dev doc, here are the substitutions to perform:
https://github.com/mathml-refresh/mathml/issues/75#issuecomment-523016332

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

I don't think these length values appear in the MathML reference documentation other than here: https://developer.mozilla.org/en-US/docs/Web/MathML/Attribute/Values#Constants I've updated that section.

Please add 'dev-doc-needed' to the bug that removes this in a stable Firefox version.

You need to log in before you can comment on or make changes to this bug.