1574859 - icons on the tool bar are suddenly three times as big

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[musiquegraeme]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Opened Thunderbird

Actual results:

The icon on the tool bar was perhaps three times its usual size - its the default green jigsaw piece icon.

Expected results:

It should have been the normal size - same as the standard icons.. This icon is there because I have a Browser_action entry in my manifest.json. The same thing happens to the icons that I have in the compose window but I shrunk the icon. With this icon from the browser_action entry - it is the default icon and I can't resize it and anyway I feel like this is a bug to be fixed... though minor.

Comment 1

[Wayne Mery (:wsmwk)]

Do you see it also when Thunderbird is restarted with addons disabled?

Comment 2

[musiquegraeme]

I presume not as the problem icons are all related to an addon - the default icon that comes when I have browser_action in the manifest.json and the icon that I use in my addon in the composer window. This had always been OK until the last but one beta and it increased. I coped with that by reducing it's size. Then in the latest beta, today, for some reason the browser_action icon stayed (previously it had only been there for a short time - don't know why - I removed it from the manifest.json) It was also super large.

Comment 3

[Wayne Mery (:wsmwk)]

I experience something similar with the Gecko Profiler addon

Comment 4

[Jorg K (CEST = GMT+2)]

Related to bug 1572946? NI Richard for theme, Geoff for add-ons.

Comment 5

[Geoff Lankow (:darktrojan)]

Could be a toolkit add-ons thing. Even if it is the icons should have dimensions set on them but don't.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1574859-toolbarbutton-icon-size.patch

We hadn't set a icon size. With defining a 64px icon it will show it in his original size.

With set to 18px (16px + 2px padding) it's correct now. Tested with the Gecko Profiler addon.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1574859-toolbarbutton-icon-size-ESR.patch

Patch for ESR 68.

Comment 8

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2019-08-20 10-42-46.png

Comment 9

[Alessandro Castellani [:aleca]]

Comment on attachment 9086732 [details] [diff] [review]
1574859-toolbarbutton-icon-size.patch

Review of attachment 9086732 [details] [diff] [review]:
-----------------------------------------------------------------

I don't this this is a complete solution as it causes smaller icons in the today pane to grow past their original intended size.
(See screenshot above)

Comment 10

[Richard Marti (:Paenglab)]

Attachment: 1574859-toolbarbutton-icon-size.patch

Sorry, the rule wasn't specific enough.

Comment 11

[Richard Marti (:Paenglab)]

Attachment: 1574859-toolbarbutton-icon-size-ESR.patch

Patch for ESR 68.

Comment 12

[Alessandro Castellani [:aleca]]

Comment on attachment 9086739 [details] [diff] [review]
1574859-toolbarbutton-icon-size.patch

Review of attachment 9086739 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c69de8e90f22
Set a size on toolbarbutton-icon. r=aleca

Comment 14

[Jorg K (CEST = GMT+2)]

TB 69 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/ebafef38ef3df4bd69bc0d5d6fea8137bf15e837

Comment 15

[Jorg K (CEST = GMT+2)]

TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/444d8b4efa8c637fd8bd284cab142571dbdb6cf7