1575612 - Distorted Chat status toolbar icon

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca]]

The status icon in the Chat tab it's 2px taller than it should be.
We should set a fixed height for this as well.

https://searchfox.org/comm-central/rev/3d360e890307be83b936f8604a80744bde81387e/mail/components/im/themes/chat.css#788

bug 1574859 that caused the regression was uplifted to 68, right?

Comment 1

[Richard Marti (:Paenglab)]

Alessandro, please can you add a screenshot of the issue?

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2019-08-21 09-51-46.png

Sorry, I took the screenshot and forgot to upload it.

Comment 3

[Jorg K (CEST = GMT+2)]

bug 1574859 that caused the regression was uplifted to 68, right?

No, I was going to stick it onto TB 69 beta 4, but I won't do that now. The status icon looks more like an egg now :/

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1575612-statusTypeIcon.patch

This rule is no more needed with the toolbar-icon size set in bug 1574859.

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9087152 [details] [diff] [review]
1575612-statusTypeIcon.patch

Review of attachment 9087152 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. r+

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9087152 [details] [diff] [review]
1575612-statusTypeIcon.patch

Looked good to me as well, but I didn't want to steal the review ;-)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/501261e56c07
Remove the no longer needed width/padding of the statusTypeIcon toolbar-icon. r=aleca

Comment 8

[Jorg K (CEST = GMT+2)]

TB 69 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/15cdc4e6dcb7e0bd5014cd1ee77e061062b55d7c

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/bdb6f6ee088cafce4b3c269b691041d2472190d0