Closed Bug 1575605 Opened 2 months ago Closed 2 months ago

Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java)]

Categories

(Firefox for Android :: General, defect, critical)

ARM
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox-esr68 69+ verified
firefox68 --- unaffected
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: marcia, Assigned: andrei.a.lazar)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

This bug is for crash report bp-290e5829-dd2d-4d64-b473-fd8d20190821.

This crash is still a top crash in Fennec nightly as well as 68.1b7: https://bit.ly/2NmrZdG. The most recent work for this signature was done in Bug 1557661, as well the patch which landed in nightly on 8-1 - https://bugzilla.mozilla.org/show_bug.cgi?id=1562622#c24.

578 crashes/316 installations in the last 7 days on Fennec nightly.

All of the comments seem to reference crashing when rotating the phone.

No correlations from nightly, but here are some from beta:

(100.0% in signature vs 01.01% overall) build_id = 20190819150103
(20.69% in signature vs 80.42% overall) Module "scriptCache-current.bin" = true [20.69% vs 87.37% if platform = Android]
(96.55% in signature vs 42.58% overall) moz_crash_reason = MOZ_CRASH(Uncaught Java exception)
(20.69% in signature vs 80.42% overall) Module "scriptCache-child-current.bin" = true
(41.38% in signature vs 85.45% overall) Module "libfreebl3.so" = true [41.38% vs 92.84% if platform = Android]
(41.38% in signature vs 85.45% overall) Module "libsoftokn3.so" = true [41.38% vs 92.84% if platform = Android]
(41.38% in signature vs 84.88% overall) Module "ashmem (deleted)" = true [41.38% vs 92.21% if platform = Android]
(55.17% in signature vs 04.87% overall) startup_crash = 1
(51.72% in signature vs 02.80% overall) Module "hwframework.odex" = true
(55.17% in signature vs 07.10% overall) Module "hwframework.jar" = true
(48.28% in signature vs 86.97% overall) Module "cookies.sqlite-shm" = true [48.28% vs 94.48% if platform = Android]
(55.17% in signature vs 09.79% overall) android_manufacturer = HUAWEI
(44.83% in signature vs 89.45% overall) startup_crash = 0
(41.38% in signature vs 85.20% overall) Module "libnssckbi.so" = true
(48.28% in signature vs 04.25% overall) android_brand = Huawei

Java stack trace:

java.lang.NullPointerException
	at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java:130)
	at org.mozilla.gecko.home.TabMenuStrip.onConfigurationChanged(TabMenuStrip.java:135)
	at android.view.View.dispatchConfigurationChanged(View.java:14080)
	at android.view.ViewGroup.dispatchConfigurationChanged(ViewGroup.java:1582)
	at android.view.ViewGroup.dispatchConfigurationChanged(ViewGroup.java:1586)
	at android.view.ViewGroup.dispatchConfigurationChanged(ViewGroup.java:1586)
	at android.view.ViewGroup.dispatchConfigurationChanged(ViewGroup.java:1586)
	at android.view.ViewGroup.dispatchConfigurationChanged(ViewGroup.java:1586)
	at android.view.ViewGroup.dispatchConfigurationChanged(ViewGroup.java:1586)
	at android.view.ViewGroup.dispatchConfigurationChanged(ViewGroup.java:1586)
	at android.view.ViewGroup.dispatchConfigurationChanged(ViewGroup.java:1586)
	at android.view.ViewGroup.dispatchConfigurationChanged(ViewGroup.java:1586)
	at android.view.ViewGroup.dispatchConfigurationChanged(ViewGroup.java:1586)
	at android.view.ViewGroup.dispatchConfigurationChanged(ViewGroup.java:1586)
	at android.view.ViewRootImpl.updateConfiguration(ViewRootImpl.java:4655)
	at android.app.ActivityThread.handleActivityConfigurationChanged(ActivityThread.java:5564)
	at android.app.servertransaction.ActivityConfigurationChangeItem.execute(ActivityConfigurationChangeItem.java:43)
	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1948)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7050)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)

Looks like we're not quite out of the woods yet with this issue, Andrei :(

Flags: needinfo?(andrei.a.lazar)
Assignee: nobody → andrei.a.lazar
Flags: needinfo?(andrei.a.lazar)

Now performing a sanity check after grabbing the child at position due to the fact that it can be
null if the position is out of array bounds.

Attachment #9087711 - Attachment description: Bug 1575605 - Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java)] r=VladBaicu → Bug 1575605 - Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java)] (WIP) r=VladBaicu
Attachment #9087711 - Attachment description: Bug 1575605 - Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java)] (WIP) r=VladBaicu → Bug 1575605 - Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java)] r=VladBaicu

I have managed to reproduce the issue on the latest Fennec builds 69.0b17 and 70.0a1 (2019-08-25) on a Samsung Galaxy S8+ (Android 8.0.0) using the steps found in bug 1574551.

Hardware: Unspecified → ARM
Blocks: 1574551
Keywords: checkin-needed

Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4a1c144d595
Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java)] r=VladBaicu

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

Please request uplift to esr68 when you get a chance.

Flags: needinfo?(andrei.a.lazar)

Comment on attachment 9087711 [details]
Bug 1575605 - Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java)] r=VladBaicu

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a sec-high bug.
  • User impact if declined: Users with disabled home panels will encounter a crash upon screen orientation change.
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The change is small and it doesn't introduces any new behavior but rather enforces an old one by adding more sanity checks.
  • String or UUID changes made by this patch:

Beta/Release Uplift Approval Request

  • User impact if declined: Users with disabled home panels will encounter a crash upon screen orientation change.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The change is small and it doesn't introduces any new behavior but rather enforces an old one by adding more sanity checks.
  • String changes made/needed:
Flags: needinfo?(andrei.a.lazar)
Attachment #9087711 - Flags: approval-mozilla-esr68?
Attachment #9087711 - Flags: approval-mozilla-beta?

Comment on attachment 9087711 [details]
Bug 1575605 - Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java)] r=VladBaicu

At this point, we don't need this on Beta as of yesterday's merges.

Attachment #9087711 - Flags: approval-mozilla-beta? → approval-mozilla-beta-

Comment on attachment 9087711 [details]
Bug 1575605 - Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java)] r=VladBaicu

last minute, but approved for fennec 68.1...

Attachment #9087711 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+

BTW...

(In reply to Andrei Lazar from comment #7)

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a sec-high bug.

this is not a sec-high bug :)

Hi, the issue has been verified as fixed through comment 7 from bug 1574740.
I will set verified for status-firefox-esr68.

You need to log in before you can comment on or make changes to this bug.