1557661 - java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Julien Cristau [:jcristau] (back April 22)]

Seeing crashes after bug 1371217 was uplifted to 68:
https://crash-stats.mozilla.com/signature/?signature=java.lang.NullPointerException%3A%20at%20org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected%28TabMenuStripLayout.java%29&date=%3E%3D2019-05-31T09%3A08%3A00.000Z&date=%3C2019-06-07T09%3A08%3A00.000Z

java.lang.NullPointerException: Attempt to invoke virtual method 'void android.widget.TextView.setTextColor(int)' on a null object reference at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java:131) at org.mozilla.gecko.home.TabMenuStrip.onConfigurationChanged(TabMenuStrip.java:135) at android.view.View.dispatchConfigurationChanged(View.java:13048)

Comment 1

[Julien Cristau [:jcristau] (back April 22)]

Bug 1371217 was backed out of beta.

Comment 2

[Andrei Lazar]

Attachment: Bug 1557661 java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java) r=VladBaicu

Fixed an issue where we were trying to set some attributes on a null object due to the fact that
the view had not finished rendering.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e2272faa004
java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java) r=VladBaicu

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1e2272faa004

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR68 approval when you get a chance.

Comment 6

[Andrei Lazar]

Comment on attachment 9073182 [details]
Bug 1557661 java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java) r=VladBaicu

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a pretty critical bug since it can be reproduced 100% of time upon screen orientation change.
• User impact if declined: Users won't be able to change the screen orientation without getting a crash (in some particular screens) which leads to bad user experience.
• Fix Landed on Version: 68
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is small and it has been hard tested and it doesn't introduce any new behaviors, we are just adding a sanity check.
• String or UUID changes made by this patch:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9073182 [details]
Bug 1557661 java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java) r=VladBaicu

Fixes a crash caused by bug 1371217, approved for 68.1b2.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/f18a48e29fd2

Comment 9

[Diana Rus]

Hi, the issue has been checked on build Firefox Beta 68.1b1 (build 3) and not reproduced with devices:

• Google Pixel C (Android 8.0.0)
• Samsung Galaxy J7 (2016) (Android 6.0.1)
• Sony Xperia Z5 (Android 7.0)
  on platform android - api 16.
• Google Pixel 3a XL (Android 9)
  on platform android-aarch64.

Will leave the ticket unchanged until I will also make a check on an X86 device.

Comment 10

[Stefan Deiac]

Hello, I tried to reproduce the problem using Xiaomi Mi Pad 2 (Android 5.1 - x86 architecture) on the affected build of Nightly(68.0a1 2019-06-05) but I wasn't able. It seems that the x86 build is not affected.
Additionally, I verified with Samsung Galaxy Tab S3 (Android 8.0) on the same build for the API 16 architecture and I was able to reproduce the problem.
I tried with the latest version of Nightly from the archive (68.1a1 2019-07-13) and Nightly (69.0a1 2019-07-06) from treeherder and the issue is not reproducible.
I'll let the issue open until I can confirm the fix on Beta 68.1b2, thanks.

Comment 12

[Stefan Deiac]

Hello, I can confirm that the issue is not reproducible on Beta 68.1b2 using Samsung Galaxy Tab S3 (Android 8.0) and Nexus 9 (Android 7.1.1).

Comment 13

[robsmith11]

I just updated to 68.1b2 and started getting a crash with this signature almost every time my screen rotates orientation:

https://crash-stats.mozilla.org/report/index/09a424d9-782a-4565-8656-422680190722

I didn't get this with 68.1b1 or earlier. Is it the same bug or a new one?

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Indeed, this signature looks pretty high in 68.1b2. Andrei, any ideas?

Comment 15

[Andrei Lazar]

This problem is resolved by the patch from bug 1562622 which is not yet uplifted.

Comment 16

[Marcia Knous [:marcia]]

Hello Andrei: I still see a fairly significant number of crashes (over 800) in Fennec nightly, 68.1a1 even though a fix for this landed. Is there a reason why it is still showing up in nightly? Some of the comments:

*Opening phone from sleep caused Firefox to crash.
*App crashed when switched to landscape mode.
*it crashes when i use split screen

If needed, we can file a new bug. This is currently the top crash on Fennec nightly.

Comment 17

[Marcia Knous [:marcia]]

I know you also mentioned in Comment 15 that the patch in that bug would fix it, but the 2 signatures in this bug still have crashes in both 68.1b3 and 68.1b4.

Comment 18

[Andrei Lazar]

Hello, this should be fixed by Brad's patch as soon as this gets merged.

Comment 19

[sjw]

bug 1562622 comment 29 states that this should be fixed, but today's Nightly is still crashing a lot for me.

Comment 20

[Julien Cristau [:jcristau] (back April 22)]

This is still present on nightly and beta 68.1, e.g. bp-78c0abcc-5e05-490d-8bf7-6ebd00190827

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Bug 1575605 was tracking that I thought.

Comment 22

[Julien Cristau [:jcristau] (back April 22)]

sigh ok.

Comment 23

[Laurentiu Apahidean]

I retested the issue on Beta 68.2b3 and Nightly 71.0a1 using a Samsung Galaxy S9 (Android 8.0.0) and the issue does no longer occurs.

Comment 24

[Stefan Deiac]

Hello, I can't reproduce the issue on Firefox 68.2.0 using Nexus 9 (Android 7.1.1), Xiaomi Mi 8 Lite (Android 9) and OnePlus 5T(Android 9). Due to that, I'll close this ticket as verified, thanks.