1576113 - Completely grey window on startup with gfx.core-animation.enabled enabled on Mac with 10.14 SDK

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Mark Banner (:standard8)]

After bug 1574538 landed, my local Firefox builds are starting up with an almost completely grey window - the only items displayed are the window controls themselves.

Interacting with the window appears to work - I can get some popups from the bookmarks toolbar for instance.

If I download a treeherder build, then it works fine.

If I change the profile to set gfx.core-animation.enabled to false, then it starts working again.

As I'm using just the default .mozconfig with no sdk specification, I'm assuming this is a result of using the 10.14 SDK.

Comment 1

[Markus Stange [:mstange]]

Oh dear, that's certainly not the intended effect.

Comment 2

[Markus Stange [:mstange]]

This can be fixed by backing out https://hg.mozilla.org/integration/autoland/rev/2a82b5ce10e2 . I will do that tomorrow. More details to follow.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2093b28e6aa9
Back out revision 2a82b5ce10e2 because it causes trouble when building with the 10.14 SDK.
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bc07ad7cfad
Add a comment.

Comment 4

[Markus Stange [:mstange]]

Here's what the NSView hierarchy looks like when building with the 10.14 SDK:

When returning NO from _wantsFloatingTitlebar:

NSThemeFrame
    NSView // content view
        ChildView
            ...
    _NSThemeCloseWidget
    _NSThemeZoomWidget
    _NSThemeWidget
    NSThemeFrameTitleTextField

When returning YES from _wantsFloatingTitlebar:

NSThemeFrame
    NSView // content view
        ChildView
            ...
    NSVisualEffectView // full-window gray view
    NSTitlebarContainerView
        NSTitlebarView
            _NSThemeCloseWidget
            _NSThemeZoomWidget
            _NSThemeWidget
            NSTextField
        _NSTitlebarDecorationView

That NSVisualEffectView is not present when building with the 10.13 SDK or below. It's what renders the gray color. Our setContentView: override places the window's content view below that solid gray view, so nothing is shown.

To fix this, I re-instated the _wantsFloatingTitlebar override for now. I filed bug 1576387 and bug 1576391 for fixing this properly.

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2093b28e6aa9
https://hg.mozilla.org/mozilla-central/rev/0bc07ad7cfad