1576501 - NS_ERROR_FAILURE in [nsIURI.host] when typing new password into about:logins

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[tobias]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

1. in Nightly 70 (2019-08-25, fresh profile) go to about:logins
2. open Browser Console
3. click "Create New Login"
4. type into password field

Actual results:

for each keypress (or when holding down, for each keydown and -up; or when focussing the browser window), these two messages get printed in the browser console

LoginHelper: Couldn't parse origin for about:logins <unavailable> LoginHelper.jsm:261:11
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIURI.host] LoginAutoCompleteResult.jsm:427

Expected results:

no errors and warnings should appear in the browser console.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Matthew N. [:MattN]]

This is harmless but was supposed to be addressed by other bugs already. It would be nice to have.

To fix this bug one can reproduce the problem and see what line is giving the error in the Browser Console / Debugger. Then you can apply a fix like bug 1550171 did to disable login autocomplete on about: pages.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1576501 - Fail mochitest-browser about:logins tests if they write to the console unexpectedly. r?MattN

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1576501 - Don't search for login autocomplete results on about: pages. r?MattN

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1576501 - Form fields in about: pages should not get login-related information. r?MattN

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1576501 - Ignore error messages from browser-sync. r?MattN

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1576501 - Ignore expected error messages for duplicate logins. r?MattN

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1576501 - Ignore error when loading the Migration Wizard in automation. r?MattN

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/141521590579
Fail mochitest-browser about:logins tests if they write to the console unexpectedly. r=MattN
https://hg.mozilla.org/integration/autoland/rev/430ef52e684e
Don't search for login autocomplete results on about: pages. r=MattN
https://hg.mozilla.org/integration/autoland/rev/b81e421ad52a
Form fields in about: pages should not get login-related information. r=MattN
https://hg.mozilla.org/integration/autoland/rev/38ba8548f2ea
Ignore error messages from browser-sync. r=MattN
https://hg.mozilla.org/integration/autoland/rev/9642f41ccc42
Ignore expected error messages for duplicate logins. r=MattN
https://hg.mozilla.org/integration/autoland/rev/3d6215462836
Ignore error when loading the Migration Wizard in automation. r=MattN

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/141521590579
https://hg.mozilla.org/mozilla-central/rev/430ef52e684e
https://hg.mozilla.org/mozilla-central/rev/b81e421ad52a
https://hg.mozilla.org/mozilla-central/rev/38ba8548f2ea
https://hg.mozilla.org/mozilla-central/rev/9642f41ccc42
https://hg.mozilla.org/mozilla-central/rev/3d6215462836

Comment 12

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20191009213914) on Windows 10 x64, Mac 10.14, Ubuntu 16 x64.

• The ‘LoginHelper: Couldn't parse origin for about:logins <unavailable> LoginHelper.jsm:261:11’ warning message and the ‘NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIURI.host] LoginAutoCompleteResult.jsm:427’ error message are not displayed anymore on the browser console when typing a new password on the “about:logins” page.