1576911 - [Fission][MSU Capstone] Page thumbnailer should use Fission for messaging

Status: RESOLVED FIXED

(Firefox :: General, task, P3)

Description

[Beth Rennie [:beth] (she/her)]

This is the code that is responsible for capturing thumbnails of web pages (for the new tab page, dragging and dropping tabs, etc): https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/toolkit/actors/ThumbnailsChild.jsm

Actor spec:
https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/toolkit/modules/ActorManagerParent.jsm#363-373

This should use the fission-compatible actor infrastructure to send messages instead.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Instead of straight-porting the actor, this might involve using the new drawSnapshot API from graphics that was implemented in bug 1475139.

Comment 2

[Scott [:thecount] Downe]

Are you all working on this? I set this to P3 for now until we know better what release we want it.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

This is a bug that we opened for an MSU student to take[1], so expect some activity in the next few weeks. :)

[1]: Barret, Gijs and myself are mentoring some students from MSU on some Fission bugs as part of a Capstone course

Comment 4

[u646291]

Attachment: Bug 1576911 - Make ThumbnailsChild a JSWindowActorChild instead of ActorChild

Comment 5

[Scott [:thecount] Downe]

Might be related? I've been looking at what might be wrong in https://bugzilla.mozilla.org/show_bug.cgi?id=1539947

The comments in the ticket are a bit out dated though.

Comment 6

[u646291]

Attachment: Bug 1576911 - Make ThumbnailsChild a JSWindowActorChild instead of ActorChild

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e9893047ae9
Make ThumbnailsChild a JSWindowActorChild instead of ActorChild r=Gijs

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5e9893047ae9

Comment 9

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732