Closed Bug 1576911 Opened 5 months ago Closed 2 months ago

[Fission][MSU Capstone] Page thumbnailer should use Fission for messaging

Categories

(Firefox :: General, task, P3)

task

Tracking

()

RESOLVED FIXED
Firefox 72
Fission Milestone M4
Tracking Status
firefox72 --- fixed

People

(Reporter: barret, Assigned: me, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

This is the code that is responsible for capturing thumbnails of web pages (for the new tab page, dragging and dropping tabs, etc): https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/toolkit/actors/ThumbnailsChild.jsm

Actor spec:
https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/toolkit/modules/ActorManagerParent.jsm#363-373

This should use the fission-compatible actor infrastructure to send messages instead.

Summary: [Fission] Page thumbnailer should use Fission for messaging → [Fission][MSU Capstone] Page thumbnailer should use Fission for messaging

Instead of straight-porting the actor, this might involve using the new drawSnapshot API from graphics that was implemented in bug 1475139.

Priority: -- → P3

Are you all working on this? I set this to P3 for now until we know better what release we want it.

This is a bug that we opened for an MSU student to take[1], so expect some activity in the next few weeks. :)

[1]: Barret, Gijs and myself are mentoring some students from MSU on some Fission bugs as part of a Capstone course

Assignee: nobody → green114
Status: NEW → ASSIGNED

Might be related? I've been looking at what might be wrong in https://bugzilla.mozilla.org/show_bug.cgi?id=1539947

The comments in the ticket are a bit out dated though.

Attachment #9105839 - Attachment is obsolete: true
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5e9893047ae9
Make ThumbnailsChild a JSWindowActorChild instead of ActorChild r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
Regressions: 1595093
Regressions: 1604780
Component: New Tab Page → General
You need to log in before you can comment on or make changes to this bug.