Closed Bug 1577005 Opened 6 years ago Closed 6 years ago

Add commit support for autofill

Categories

(GeckoView :: General, enhancement, P1)

Product:
GeckoView
Component:
General
Platform:
Unspecified
Android
Type:
enhancement

Tracking

(firefox69 wontfix, firefox70 wontfix, firefox71 wontfix, firefox72 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox69 --- wontfix
firefox70 --- wontfix
firefox71 --- wontfix
firefox72 --- fixed

People

(Reporter: snorp, Assigned: esawin)

References

Details

(Whiteboard: [geckoview:m1910] [geckoview:m1911])

Attachments

(5 files, 4 obsolete files)

Bug 1577005 - [1.6] Add autofill commit support.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1577005 - [2.4] Add autofill commit tests.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1577005 - [3.1] Ensure node value updates are propagated through the API.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1577005 - [4.1] Fix inconsistent naming.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1577005 - [5.0] Fix changelog syntax.
47 bytes, text/x-phabricator-request
Details | Review

We currently don't allow new or updated passwords to be saved via the autofill system. We should add that.

LoginManagerContent._onFormSubmit handles the various triggers for "form submission" (no actual <form> necessary). We could hook in there in the content process or you could listen for the "PasswordManager:onFormSubmit" message manager message which already tries to filter out things like CC fields.

We need this to make GeckoSession autofill API available to API levels 21-25.

status-firefox69: --- → wontfix
status-firefox70: --- → affected
Priority: -- → P2
Whiteboard: [geckoview:fenix:m8]

Emily suggests login autofill be a top priority for October ([geckoview:m1910]).

status-firefox70: affected → fix-optional
Whiteboard: [geckoview:fenix:m8] → [geckoview:m1910]
Whiteboard: [geckoview:m1910]
Whiteboard: [geckoview:m1910]

Do we want to include this bug in our October sprint?

status-firefox71: affected → ?
Priority: P2 → P1

Do we want to include this bug in our October sprint?

Yes.

Assignee: nobody → snorp
status-firefox71: ? → affected

Depends on D49310

Depends on D49311

Assignee: snorp → esawin
Depends on: 1567175, 1591462

Moving the refactoring work out into bug 1591462.

Attachment #9101315 - Attachment is obsolete: true
Attachment #9101313 - Attachment is obsolete: true

Depends on D51185

Attachment #9101314 - Attachment is obsolete: true

Rolling over to November sprint.

status-firefox71: affected → wontfix
status-firefox72: --- → affected
OS: All → Android
Whiteboard: [geckoview:m1910] → [geckoview:m1910] [geckoview:m1911]
Attachment #9105400 - Attachment description: Bug 1577005 - [1.1] Add autofill commit support. → Bug 1577005 - [1.2] Add autofill commit support.
Attachment #9105400 - Attachment description: Bug 1577005 - [1.2] Add autofill commit support. → Bug 1577005 - [1.3] Add autofill commit support.
Attachment #9105401 - Attachment description: Bug 1577005 - [2.1] Add autofill commit tests. → Bug 1577005 - [2.2] Add autofill commit tests.

Depends on D51922

Attachment #9105400 - Attachment description: Bug 1577005 - [1.3] Add autofill commit support. → Bug 1577005 - [1.4] Add autofill commit support.
Attachment #9105401 - Attachment description: Bug 1577005 - [2.2] Add autofill commit tests. → Bug 1577005 - [2.3] Add autofill commit tests.
Attachment #9106717 - Attachment description: Bug 1577005 - [3.0] Ensure node value updates are propagated through the API. → Bug 1577005 - [3.1] Ensure node value updates are propagated through the API.
Attachment #9106718 - Attachment description: Bug 1577005 - [4.0] Fix inconsistent naming. → Bug 1577005 - [4.1] Fix inconsistent naming.
Attachment #9105401 - Attachment description: Bug 1577005 - [2.3] Add autofill commit tests. → Bug 1577005 - [2.4] Add autofill commit tests.
Attachment #9105400 - Attachment description: Bug 1577005 - [1.4] Add autofill commit support. → Bug 1577005 - [1.5] Add autofill commit support.
Attachment #9105400 - Attachment description: Bug 1577005 - [1.5] Add autofill commit support. → Bug 1577005 - [1.6] Add autofill commit support.
Pushed by esawin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/741f4a9a2f64 [1.6] Add autofill commit support. r=MattN https://hg.mozilla.org/integration/autoland/rev/56bf24c7a31a [2.4] Add autofill commit tests. r=snorp https://hg.mozilla.org/integration/autoland/rev/a69b9ff498cd [3.1] Ensure node value updates are propagated through the API. r=snorp,geckoview-reviewers https://hg.mozilla.org/integration/autoland/rev/f1815ce6163a [4.1] Fix inconsistent naming. r=geckoview-reviewers,agi

Depends on D51923

Attachment #9109176 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: