1577259 - Missing scrollbar in Proxy Window Setup TH 68.0

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect)

Description

[fademind]

Attachment: scr-1567014183-001.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Open Settings > Advanced > Network > Connection > Setup

Actual results:

Scrollbar is missing and OK / Cancel buttons are to low on screen not visible.

Expected results:

Enable scrollbar as it is in Firefox.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1577259-overflow-dialog.patch

This is 68 only. 69 and Daily are working.

The issue is, that the needed overflow rules are in the file https://searchfox.org/mozilla-central/source/toolkit/content/widgets/dialog.js#166 which doesn't exist in 68. Adding the rule to dialog.css should fix it.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9088812 [details] [diff] [review]
1577259-overflow-dialog.patch

OK, I saw this and pulled it bigger. OK, a scrollbar is better. I haven't tried, have you?

Comment 3

[Richard Marti (:Paenglab)]

I haven't tried but I copied it from https://searchfox.org/mozilla-esr68/source/browser/themes/shared/incontentprefs/dialog.inc.css#26. So it should work.

Comment 4

[Jorg K (CEST = GMT+2)]

I don't think this works. I have an unpacked omni.ja here and made the change and it has no effect.

Comment 5

[Richard Marti (:Paenglab)]

Works for me.

Comment 6

[Jorg K (CEST = GMT+2)]

Works for me, too, after starting again.

Comment 7

[Jorg K (CEST = GMT+2)]

TB 68.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/1c299e30ce859e618e51cf9e2742aa8bd5654930

Comment 8

[Jorg K (CEST = GMT+2)]

Working :-)