how to *disable* dark mode
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird_esr6869+, thunderbird_esr78?, thunderbird70 fixed, thunderbird71 fixed)
People
(Reporter: harri, Assigned: Paenglab)
References
Details
Attachments
(2 files, 1 obsolete file)
|
112 bytes,
text/plain
|
Details | |
|
3.01 KB,
patch
|
aleca
:
review+
darktrojan
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.132 Safari/537.36
Steps to reproduce:
run thunderbird on Linux (Debian sid) in safe-mode, or select the "Light" theme in thunderbird
Actual results:
the folder pane and the message overview pane are still in dark mode. Dark background, white fonts
Expected results:
It should use a light background and dark font for all parts of thunderbird. The light and dark theme are supposed to override the system's config settings, AFAIU. Thunderbird's default theme should give me gtk's color scheme.
|
||
Comment 1•5 years ago
|
||
Could that be because "gtk-application-prefer-dark-theme" is set to "1"?
If I change my system theme from Adwaita(default) to Adwaita Dark using Tweaks, the Folder and Message panes are dark no matter if I use the Light or Default theme in Thunderbird. They work as expected with the default Adwaita theme.
|
Assignee | |
Comment 2•5 years ago
|
||
You could try to set in TB Preferences > Advanced > General and clicking the "Config Editor". Then add a new integer pref ? gtk-application-prefer-dark-theme and set it to 0. Restart TB.
|
||
Comment 3•5 years ago
|
||
Please close the bug when you've sorted this out.
|
||
Comment 4•5 years ago
|
||
Didn't help. I selected the light theme in TB, created and set gtk-application-prefer-dark-theme to 0 (integer), and restarted TB. The folder pane and the message overview pane are still white font and black background.
|
|
Assignee | |
Comment 5•5 years ago
|
||
The light theme doesn't style everything like the dark theme. Firefox is the same.
So we need to add more colours to the light theme to look light when the system has a dark theme.
|
|
Assignee | |
Comment 7•5 years ago
|
||
This would fix the issue.
Unfortunately this would remove the vibrancy effect of the trees on Mac.
Geoff, is it possible to differ in the manifest file between platforms and only add the new colour definitions to Linux and Windows? Or is it somehow possible to do this in the moz.build file?
|
||
Comment 8•5 years ago
|
||
You could run it through the pre-processor by listing it in EXTRA_PP_JS_MODULES instead of EXTRA_JS_MODULES.
What is this vibrancy effect you speak of?
|
|
Assignee | |
Comment 9•5 years ago
|
||
(In reply to Geoff Lankow (:darktrojan) from comment #8)
What is this vibrancy effect you speak of?
The tree background has a transparent milk glass effect.
|
|
Assignee | |
Comment 10•5 years ago
|
||
Thanks, this now uses the preprocessor.
Best you test it on Linux with a dark system theme and set the light theme. This should now set the correct colours for the trees. On Calendar are some parts not light but this is bug 1579411.
Alessandro, for the selected treeitem I've chosen #2292d0 like we already use for the in-content checkmarks and radio buttons. Or do yu want that I use #0a84ff or #0060df which are used for the selected category in the prefs or the Add-ons manager?
Geoff, please can you check the calendar CSS changes?
|
|
||
Comment 11•5 years ago
|
||
Comment on attachment 9091473 [details] [diff] [review] 1577591-light-theme-full-colors.patch Review of attachment 9091473 [details] [diff] [review]: ----------------------------------------------------------------- This looks okay to me.
|
||
Comment 12•5 years ago
|
||
Comment on attachment 9091473 [details] [diff] [review] 1577591-light-theme-full-colors.patch Review of attachment 9091473 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
||
Comment 13•5 years ago
|
||
Comment on attachment 9091473 [details] [diff] [review] 1577591-light-theme-full-colors.patch 70 beta 1 and 68.1 were build last night, so I'm really hoping not to do any release for at least 10 days now.
|
||
Comment 14•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d37caf20cf1f
[Light theme] Set theme colors for the trees on Linux and Windows too. r=aleca,darktrojan DONTBUILD
|
|
||
Updated•5 years ago
|
|
|
||
Comment 15•5 years ago
|
||
TB 70 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/f1fc5fb31f6d9d3fe96df16b6ea56e30d6631493
|
|
||
Comment 16•5 years ago
|
||
TB 68.1.1 or TB 68.2:
https://hg.mozilla.org/releases/comm-esr68/rev/ae285ad099274bb40dbbdd8ad4346addcf6205c4
|
||
Comment 17•4 years ago
|
||
In the last 78.2.1 version of TB for Windows I still see that the dark theme elements are preset when using the light theme: eg, when I click on customise toolbar in the composing email window I see BLACK spaces and solid borders https://prnt.sc/uc64ii, the same issues with the customise toolbar in the main window https://prnt.sc/uc64vs.
Is it possible completely disable dark theme in TB?
|
|
||
Comment 18•4 years ago
|
||
In the last 78.2.1 version of TB for Windows I still see that the dark theme elements are preset when using the light theme: eg, when I click on customise toolbar in the composing email window I see BLACK spaces and solid borders https://prnt.sc/uc64ii, the same issues with the customise toolbar in the main window https://prnt.sc/uc64vs.
Is it possible completely disable dark theme in TB?
Description
•