1577987 - Messages can't be moved from "Search Messages" windows via drag and drop (TB 68)

Status: VERIFIED FIXED

(Thunderbird :: Search, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1577970 +++

See bug 1577970 comment #5 for a regression window:
Regression window(drag and drop issue):
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=9c6c4038b3b5ab074c1d9c2bf91bae0a062adaab&tochange=89435f04afee556e91d8f17634cd377dff5ac8d2
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b4aeb99d1cb601e5a5288ca05630913fa8528a1c&tochange=6862624e24d005fb4f8fb07c6800d2acef1d287e

Comment 1

[:aceman]

Attachment: 1577987.patch

So really the bug 1446609 removed the utilityOverlay.js, which is needed for some helper function called as part of dragging. So dropping was broken since then.
But then later bug 297251 removed the ondragstart event on the message rows and so since then even starting to drag wasn't working.

The third !tab hunk is just a polishing as when you try to drag over something outside the 3-pane tab (like main toolbar or error console) you get error in this _getDragTargetTab() as there is no target tab. It seems the callers must handle a null returned as there are already just return values in the function.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9089618 [details] [diff] [review]
1577987.patch

Nice detective work. Did I say "missing script". I was 50% right.

Yes, bug 297251 removed
https://hg.mozilla.org/comm-central/rev/f6e91a51bd51#l2.119
<treechildren ondragstart="ThreadPaneOnDragStart(event);"/>
and added
https://hg.mozilla.org/comm-central/rev/f6e91a51bd51#l4.201
<treechildren/>

I think I'll blame it on the reviewer over there ;-)

Comment 3

[alta88]

heh, yes it was removed because dnd didn't work, and it wasn't obvious it should or even be useful from there. i'll take the blame off aceman..

that dialog should really be integrated into 3pane. it's always being left out; look how long it took for someone to take pity on bug 297251.

Comment 4

[Jorg K (CEST = GMT+2)]

Well, the drop part didn't work when you got to it. But it all worked in TB 60.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ebe8511fae07
fix drag and drop of messages for Search messages dialog by adding missing utilityOverlay.js and dragstart event handler. r=jorgk DONTBUILD

Comment 6

[Jorg K (CEST = GMT+2)]

TB 68.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/17f7cf303847a612b530a03ec852d71647f14469

Comment 7

[Jorg K (CEST = GMT+2)]

Working in 68.1.