Closed Bug 1578291 Opened 1 year ago Closed 1 year ago

Megabar breaks some parts of url highlight

Categories

(Firefox :: Address Bar, defect, P1)

defect
Points:
3

Tracking

()

RESOLVED DUPLICATE of bug 1580538

People

(Reporter: mak, Unassigned)

References

Details

entering a url and blurring the urlbar used to highlight (de-emphasize) the url, with megabar on it doesn't.

Note however we are evaluating not applying the de-emphasized on invalid pageproxystate for bug 1577539, thus we should take a decision about that. Anyway worth checking what broke.

we should also check test coverage with mb on.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1577472

bug 1577472 didn't change this, afaict.

Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---

A simple test is loading a page, clicking on the megabar, then clicking again on content. The highlighting gets lots.

As I said in comment 0, we should evaluate whether we want to highlight a non-loaded url or not, but anyway we need a test to check the decided behavior.
I think we should only apply the highlight on pageproxystate == "valid", a test should verify we do that.

(In reply to Marco Bonardo [::mak] from comment #2)

bug 1577472 didn't change this, afaict.

Right, we filed bug 1580538. There's some background information there about why bug 1577472 didn't fix it and what my plan is.

Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1580538

Ok, we'll use the security bug for the pageproxystate fix.

You need to log in before you can comment on or make changes to this bug.