1577472 - Always use position:absolute for the megabar so it doesn't get reframed on focus

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Dão Gottwald [:dao]]

The breakout on focus breaks drag-selecting in the URL.

Comment 1

[Harry Twyford]

I've added click-selects-all to this bug since both issues have the same root cause. Some testing shows that this is probably related to the setting of position: absolute on #urlbar[breakout]. Remove that rule and both click and drag work fine. It seems like setting position: absolute causes the UrlbarInput._on_click handler to "forget" what it was doing. That is, it no longer recognizes mouseup to complete the click event.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1577472 - Always use position:absolute for the megabar so it doesn't get reframed on focus

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d53fda7ac1e
Always use position:absolute for the megabar so it doesn't get reframed on focus r=harry

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/0d53fda7ac1e

Comment 7

[Kestrel]

Not fixed for me with latest Nightly on Windows 10 and Ubuntu 19.04, drag-selecting and click-selects-all still break when focusing the megabar.

Comment 8

[Dão Gottwald [:dao]]

(In reply to Kestrel from comment #7)

Not fixed for me with latest Nightly on Windows 10 and Ubuntu 19.04, drag-selecting and click-selects-all still break when focusing the megabar.

Thanks, I can confirm this, will file a new bug.