1578982 - Category color not displayed in calendar if category name contains space or other escaped non-ASCII characters

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Marc Maeder]

Attachment: 2019-09-05_Bug_Mozilla_Thunderbird_V68.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

If the category name contains a space e.g. "MC Bern", then the selected color is not displayed in the calendar. This problem is since version 68.

Actual results:

The category color is only displayed in light gray in the calendar.

Expected results:

None of the selected colors are displayed in the calendar. This only works if the category name does not contain a space. Can you make spaces in the category name possible again with the colors?

Comment 2

[Stefan Sitter [:ssitter]]

Could the be regression from bug 1561528 too?

Comment 3

[Geoff Lankow (:darktrojan)]

Yes it is. The space is getting doubly-encoded.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: 1578982-category-css-1.diff

Comment 5

[Paul Morris [:pmorris]]

Comment on attachment 9092947 [details] [diff] [review]
1578982-category-css-1.diff

Review of attachment 9092947 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.  With this patch the problem goes away.  Events have the correct category color applied when the category name has a space.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/944c4a8f2b23
Fix category colour display if category name contains space; r=pmorris

Comment 7

[Jorg K (CEST = GMT+2)]

TB 70 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/f402ca19bdad242060bb2e2b204b6df2580b0a2c

Comment 8

[Jorg K (CEST = GMT+2)]

TB 68.1.1 ESR / Cal 7.0:
https://hg.mozilla.org/releases/comm-esr68/rev/7d67effb480b0cb42e6ccb6a73a95ceb88d45570