1579849 - [Wayland] Optimize cached rendering to wl_buffer for widget.wayland_cache_mode=1

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

Optimize and fix direct rendering to wl_buffer when partional buffering is enabled (widget.wayland_cache_mode = 1) which makes this mode usable in most of the cases.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1579849 - [Wayland] Optimize cached rendering to wl_buffer for widget.wayland_cache_mode=1, r=jhorak

• When widget.wayland_cache_mode=1 use direct rendering to wl_buffer only when there isn't any
  cached rendering pending and we're updating one big piece of screen (video playback/scrolling etc..)

• Disable frame callback commits between WindowSurfaceWayland::Lock and WindowSurfaceWayland::Commit
  as the buffer can be updated by gecko compositor

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c31093a3a757
[Wayland] Optimize cached rendering to wl_buffer for widget.wayland_cache_mode=1, r=jhorak

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c31093a3a757

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9091426 [details]
Bug 1579849 - [Wayland] Optimize cached rendering to wl_buffer for widget.wayland_cache_mode=1, r=jhorak

Beta/Release Uplift Approval Request

• User impact if declined: Fixes part of rendering artifacts on Wayland.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1579823
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Wayland/Linux only.
• String changes made/needed: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9091426 [details]
Bug 1579849 - [Wayland] Optimize cached rendering to wl_buffer for widget.wayland_cache_mode=1, r=jhorak

Wayland fix, approved for 70.0b8.

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a358333fb896