1580165 - $0 is not working with fission enabled

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Alexandre Poirot [:ochameau]]

This is about this code, calling evaluateJSAsync on the top level target's web console front instead of using the selected node's target.

https://searchfox.org/mozilla-central/source/devtools/client/webconsole/actions/input.js#81-84

Comment 1

[Alexandre Poirot [:ochameau]]

(a wip patch is in progress)

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1580165 - fix selected node for console; r=ochameau

Comment 3

[Alexandre Poirot [:ochameau]]

Note that bug 1588682 might fix that, or the other way around.

Comment 4

[Jason Laster [:jlast]]

Attachment: Bug 1580165 - fix selected node for console; r=nchevobbe

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42823d984687
fix selected node for console; r=nchevobbe

Comment 6

[Arthur Iakab [arthur_iakab]]

Backed out changeset 42823d984687 (bug 1580165) for causing devtools failures on browser_toolbox_remoteness_change.js. CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/7ff2a34b51573d1e6a1edce727472746156ca7a4

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=273332970&resultStatus=testfailed%2Cbusted%2Cexception&revision=42823d984687e747ee90d83ec9e5f021f851ac79&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux64%2Fdebug-mochitest-devtools-chrome-e10s-1%2Cm%28dt1%29

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=273332970&repo=autoland

Jason can you please take a look?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15234f683370
fix selected node for console; r=nchevobbe

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/15234f683370

Comment 9

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732