1580542 - Allow Users To Control How Many Pocket Stories Are Displayed in New Tab

Status: NEW

(Firefox :: Pocket, enhancement, P2)

Description

[Tawanda Kanhema]

Attachment: Fx-69-New.png

• Firefox 69 New Tab layout displays 3 columns and 7 rows of stories, without the option for users to select how many rows are displayed.
• Provide the option for users to choose their preferred New Tab layout.

Comment 1

[Tawanda Kanhema]

Attachment: Fx-69.png

Comment 2

[Jessilyn Davis]

@wolasi - can you give us some UX specs for this during 71 nightly for consideration for Engineering for 72? (There's a lot to consider here with today's version vs. future layouts and how we want to approach this)

Comment 4

[jscher2000]

Attachment: Fx70-about-preferences-home-recommended-by-pocket.png

I see a control for rows preference in Developer Edition but not in Nightly. That's strange!

Comment 5

[jscher2000]

I think the code at lines 103-107 of AboutPreferences.jsm (dxr) may be causing this:

100  handleDiscoverySettings(sections) {
101    // Deep copy object to not modify original Sections state in store
102    let sectionsCopy = JSON.parse(JSON.stringify(sections));
103    sectionsCopy.forEach(obj => {
104      if (obj.id === "topstories") {
105        obj.rowsPref = "";
106      }
107    });
108    return sectionsCopy;
109  }

Similar code for Highlights was removed in bug 1559536 (Fx69). What happens if these lines do not run? Does that section get the rows control just like Highlights? (Sorry, I have no idea how to test such things myself.)

Also, maxRows could be increased to 7 here:

https://dxr.mozilla.org/mozilla-central/source/browser/components/newtab/lib/SectionsManager.jsm#70

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:thecount, since the bug has high priority and recent activity, could you have a look please?

For more information, please visit auto_nag documentation.