1580561 - Extend mozAddonManager API to allow AMO to handoff abuse reports to the integrated abuse report panel

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As part of Bug 1561022 ("handing off AMO abuse report flow to Firefox about:addons") we need to be extend the mozAddonManager API to allow AMO to ask Firefox to open the abuse report panel integrated into Firefox.

The currently identified additions:

• navigator.mozAddonManager.abuseReportPanelEnabled

  • A read-only boolean attribute, to be used by AMO to detect if a Firefox instance supports the abuse report handoff and it is currently enabled

• Promise<bool> navigator.mozAddonManager.reportAbuse(addonId)

  • A new method defined on the amWebAPI AddonManager object, to be used by AMO to start an abuse report flow on both installed or not-installed extension.
  • Firefox will check if the addonId is from an installed extension:
    • If the extension is already installed, the addon metadata is available locally
    • If the extension is not installed, the addon metadata will be retrieved from AMO (using the AMO /api/v4/addons/addon/ API endpoint)
  • Returns a promise that resolves to a boolean:
    • true if the report has been submitted successfully
    • false if the user cancelled the report.
  • Rejects to an error when Firefox fails to open an abuse report panel or fails to submit the report successfully

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1580561 - Part 1: AbuseReporter should retrieve the addon details from AMO for non installed addons.

Depends on D46019

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1580561 - Part 1a: Add test case for the AMO details used by the abuse report panel.

Depends on D46021

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1580561 - Part 1b: Add new abuse report errors types in the addonsManager.report telemetry event definition.

Depends on D46023

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1580561 - Part 2: Extend mozAddonManager API to allow AMO to handoff reports to the integrated abuse report panel.

Depends on D46024

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1580561 - Part 2a: Add amo entry point to telemetry event definition and related test assertions.

Depends on D46025

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: data-review-request-bug-1580561.md

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9093569 [details]
data-review-request-bug-1580561.md

Hi Chris,
the data review request attached to this bug is not exactly about a new data collection, it is related to some updates applied on an existing one (introduced in Bug 1544927), and so this new request just mentions what kind of changes we are applying in the attached patches and why (and also what is unchanged from Bug 1544927 data review request).

(The patches relevant/related to this data review request are [D46024](https://phabricator.services.mozilla.com/D46024) and [D46201](https://phabricator.services.mozilla.com/D46201)).

Comment 8

[Chris H-C :chutten]

Comment on attachment 9093569 [details]
data-review-request-bug-1580561.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Events.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Events.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 73.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. Luca is responsible for renewing or removing the collection before it expires in Firefox 73.

---
Result: datareview+

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcdbfc80be95
Part 1: AbuseReporter should retrieve the addon details from AMO for non installed addons. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/46c630c56f32
Part 1a: Add test case for the AMO details used by the abuse report panel. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/3b72d59e4318
Part 1b: Add new abuse report errors types in the addonsManager.report telemetry event definition. r=janerik
https://hg.mozilla.org/integration/autoland/rev/55e2f4fa70b5
Part 2: Extend mozAddonManager API to allow AMO to handoff reports to the integrated abuse report panel. r=kmag,zombie,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/efcaa196ab66
Part 2a: Add amo entry point to telemetry event definition and related test assertions. r=janerik

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/fcdbfc80be95
https://hg.mozilla.org/mozilla-central/rev/46c630c56f32
https://hg.mozilla.org/mozilla-central/rev/3b72d59e4318
https://hg.mozilla.org/mozilla-central/rev/55e2f4fa70b5
https://hg.mozilla.org/mozilla-central/rev/efcaa196ab66

Comment 11

[Victor Carciu]

Verified as fixed in FF71 71.0b11 using Windows 10x64 and MacOS Catalina 10.15.

I will attach a postfix video.

Comment 12

[Victor Carciu]

Attachment: Postfix video