Closed Bug 1580602 Opened 5 years ago Closed 5 years ago

Implement basic MediaSession API

Categories

(Core :: Audio/Video: Playback, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

()

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

Implement basic MediaSession interface. Specifically, we should at least implement "play" and "pause" operations.

Create dummy implementation for MediaSession interfaces. The files are
generated by running ./mach webidl-example with necessary changes to
make it buildable.

Implement the MediaMetadata interface. The API will be enabled behind a
pref.

Implement the setActionHandler interface. The API will be enabled behind
a pref.

Blocks: 1580623
Blocks: 1582508
Blocks: 1582509
Blocks: 1582569
Attachment #9092197 - Attachment description: Bug 1580602 - P1: Implement a dummy MediaSession interface. → Bug 1580602 - P1: Implement a blank MediaSession interface.
Keywords: checkin-needed

Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a52a67311e2
P1: Implement a blank MediaSession interface. r=bzbarsky

Keywords: checkin-needed

Backed out changeset 3a52a67311e2 (Bug 1580602) to reland with part2 and part3

Failed to land the second part:

Landings for Stack Containing D45457
Failed to Land
On Thu, October 10, 2019, 10:17 AM GMT+3, by dvarga@mozilla.com.
Revisions: D45456 diff 174994 ← D45457 diff 174995
Details: applying /tmp/tmphJZOiq 1 out of 1 hunk ignored -- saving rejects to file dom/webidl/moz.build.rej 2 out of 2 hunks ignored -- saving rejects to file dom/webidl/Navigator.webidl.rej 1 out of 1 hunk ignored -- saving rejects to file dom/media/moz.build.rej 3 out of 3 hunks ignored -- saving rejects to file dom/base/Navigator.h.rej 4 out of 4 hunks ignored -- saving rejects to file dom/base/Navigator.cpp.rej abort: patch command failed: exited with status 256

I've tried to land from the console, to land all three at the same time, same errors:

applying /tmp/tmpOYq4OH
patching file dom/webidl/moz.build
Hunk #1 FAILED at 656
1 out of 1 hunks FAILED -- saving rejects to file dom/webidl/moz.build.rej
patching file dom/webidl/Navigator.webidl
Hunk #1 FAILED at 16
1 out of 2 hunks FAILED -- saving rejects to file dom/webidl/Navigator.webidl.rej
file dom/webidl/MediaSession.webidl already exists
1 out of 1 hunks FAILED -- saving rejects to file dom/webidl/MediaSession.webidl.rej
patching file dom/media/moz.build
Hunk #1 FAILED at 44
1 out of 1 hunks FAILED -- saving rejects to file dom/media/moz.build.rej
file dom/media/mediasession/moz.build already exists
1 out of 1 hunks FAILED -- saving rejects to file dom/media/mediasession/moz.build.rej
file dom/media/mediasession/MediaSession.h already exists
1 out of 1 hunks FAILED -- saving rejects to file dom/media/mediasession/MediaSession.h.rej
file dom/media/mediasession/MediaSession.cpp already exists
1 out of 1 hunks FAILED -- saving rejects to file dom/media/mediasession/MediaSession.cpp.rej
file dom/media/mediasession/MediaMetadata.h already exists
1 out of 1 hunks FAILED -- saving rejects to file dom/media/mediasession/MediaMetadata.h.rej
file dom/media/mediasession/MediaMetadata.cpp already exists
1 out of 1 hunks FAILED -- saving rejects to file dom/media/mediasession/MediaMetadata.cpp.rej
patching file dom/base/Navigator.h
Flags: needinfo?(cchang)
Backout by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e9334441c41
Backed out changeset 3a52a67311e2 to reland with part2 and part3

Daniel, can you rebase and try applying patch again? I can apply patches without any errors.
I guess there are some mistakes in the operations since the following error messages doesn't seems reasonable when applying patch 2 on top of patch 1. Or can you give me the .rej files, via IRC/slack or upload them here, so I can take a look?

(In reply to Daniel Varga [:dvarga] from comment #5)

Backed out changeset 3a52a67311e2 (Bug 1580602) to reland with part2 and part3

Failed to land the second part:

Landings for Stack Containing D45457

So this is patch 2.

Failed to Land
On Thu, October 10, 2019, 10:17 AM GMT+3, by dvarga@mozilla.com.
Revisions: D45456 diff 174994 ← D45457 diff 174995
Details: applying /tmp/tmphJZOiq 1 out of 1 hunk ignored -- saving rejects to file dom/webidl/moz.build.rej 2 out of 2 hunks ignored -- saving rejects to file dom/webidl/Navigator.webidl.rej 1 out of 1 hunk ignored -- saving rejects to file dom/media/moz.build.rej 3 out of 3 hunks ignored -- saving rejects to file dom/base/Navigator.h.rej 4 out of 4 hunks ignored -- saving rejects to file dom/base/Navigator.cpp.rej abort: patch command failed: exited with status 256

I've tried to land from the console, to land all three at the same time, same errors:

applying /tmp/tmpOYq4OH
patching file dom/webidl/moz.build
Hunk #1 FAILED at 656
1 out of 1 hunks FAILED -- saving rejects to file dom/webidl/moz.build.rej
patching file dom/webidl/Navigator.webidl
Hunk #1 FAILED at 16

The dom/webidl/moz.build, dom/webidl/Navigator.webidl are not modified in patch 2. They are modified in patch 1. If you can apply the patch 1 without any error, I don't know how there errors from.

1 out of 2 hunks FAILED -- saving rejects to file dom/webidl/Navigator.webidl.rej
file dom/webidl/MediaSession.webidl already exists
1 out of 1 hunks FAILED -- saving rejects to file dom/webidl/MediaSession.webidl.rej
patching file dom/media/moz.build
Hunk #1 FAILED at 44
1 out of 1 hunks FAILED -- saving rejects to file dom/media/moz.build.rej
file dom/media/mediasession/moz.build already exists

Where is dom/media/mediasession/moz.build from? dom/media/mediasession/moz.build is introduced in patch 1 (D45456), not in patch 2 (D45457). I don't see why it already exists.

Flags: needinfo?(cchang) → needinfo?(dvarga)
Keywords: checkin-needed
Flags: needinfo?(dvarga)

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c90724f42fc
P1: Implement a blank MediaSession interface. r=bz
https://hg.mozilla.org/integration/autoland/rev/e70e3c090791
P2: Implement MediaMetadata API. r=bz
https://hg.mozilla.org/integration/autoland/rev/b4a5a6bc1d56
P3: Implement setActionHandler API. r=bz

Keywords: checkin-needed

Hi, I landed your patches manually and added bz as a reviewer. Please closed the the revisions in phabricator manually if you consider necessary.
Thanks.

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR was closed without merging

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ff571e611e2
P1: Implement a blank MediaSession interface. r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/93985de734de
P2: Implement MediaMetadata API. r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/a86601acb57b
P3: Implement setActionHandler API. r=bzbarsky

Keywords: checkin-needed
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Upstream PR merged by moz-wptsync-bot

Documentation updates:

Let me know if I missed anything.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: