1580623 - Implement the seek{back,for}ward in the MediaSession interface

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[C.M.Chang[:chunmin]]

We should implement the MediaSession API for the seek operations. However, the definition of the action handler in the current spec is problematic for the seek operations:

1. https://bugzilla.mozilla.org/show_bug.cgi?id=1112032#c68
2. https://github.com/w3c/mediasession/issues/234

Once they are solved, we should implement it.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1580623 - P1: Add `seek{back,for}ward` to MediaSessionAction and implement `seekOffset`

Depends on D45458

Comment 2

[C.M.Chang[:chunmin]]

Will only implement seek{back,for}ward in this bug.

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1580623 - P2: Fire seek{for,back}ward action handler if it's set

Depends on D45459

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d729f6a0050b
P1: Add `seek{back,for}ward` to MediaSessionAction and implement `seekOffset` r=webidl,alwu,baku
https://hg.mozilla.org/integration/autoland/rev/0333485a02ed
P2: Fire seek{for,back}ward action handler if it's set r=alwu

Comment 5

[Andrei Ciure[:aciure]]

Backed out 3 changesets (bug 1620077, bug 1580623) for causing mochitest failures
https://hg.mozilla.org/integration/autoland/rev/bc13649cbfa3ef1da31685275d0c15ac7b121704

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=293577667&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=981e37f4d18dd9845697ad099da0a9d9068c94dd&failure_classification_id=2

Comment 6

[C.M.Chang[:chunmin]]

(In reply to Andrei Ciure[:aciure] from comment #5)

Backed out 3 changesets (bug 1620077, bug 1580623) for causing mochitest failures
https://hg.mozilla.org/integration/autoland/rev/bc13649cbfa3ef1da31685275d0c15ac7b121704

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=293577667&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=981e37f4d18dd9845697ad099da0a9d9068c94dd&failure_classification_id=2

The fail is due to the patch in Bug 1620077 is pushed together. I don't think I mark D65409 as checked-in-needed. Can you just land D45459 and D66619?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96061ce60523
P1: Add `seek{back,for}ward` to MediaSessionAction and implement `seekOffset` r=webidl,alwu,baku
https://hg.mozilla.org/integration/autoland/rev/f1a3c204d3ba
P2: Fire seek{for,back}ward action handler if it's set r=alwu

Comment 8

[Andrei Ciure[:aciure]]

Done, thanks for letting me know.

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/96061ce60523
https://hg.mozilla.org/mozilla-central/rev/f1a3c204d3ba

Comment 10

[Eric Shepherd [:sheppy]]

Documentation updates:

• Submitted BCD PR 6002 with updates for Firefox 76 and adding a couple missing files
• Submitted KumaScript PR 1359 updating GroupData to include missing Media Session API stuff
• Updated Experimental features in Firefox to indicate that Media Session API is now enabled by default on Nightly as of Firefox Nightly 76
• Updated main Media Session API page
• New page: MediaSessionActionDetails.action
• New page: MediaSessionActionDetails.action
• New page: MediaSessionActionDetails.seekOffset
• New page: MediaSessionActionDetails.seekTime
• New page: MediaSessionActionDetails
• Updated: MediaSession