1582508 - Implement playbackState in Media Session interface

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[C.M.Chang[:chunmin]]

Implement MediaSessionPlaybackState in the Media Session API defined in: https://w3c.github.io/mediasession/#enumdef-mediasessionplaybackstate

Comment 1

[Alastor Wu [:alwu]]

Target it on this release cycle so mark it as P1.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1582508 - part1 : implement 'MediaSessionPlaybackState'.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1582508 - part2 : change naming of 'mState' to 'mGuessedPlaybackState'

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1582508 - part3 : create new structure 'MediaSessionInfo' to store the declared playback state for media session.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1582508 - part4 : propagate declared playback state to media session controller.

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1582508 - part5 : replace 'PlaybackState' with 'MediaSessionPlaybackState'.

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1582508 - part6 : add actual playback state in the media controller

Comment 8

[Alastor Wu [:alwu]]

Attachment: Bug 1582508 - part7 : create a chrome-only method to get the playback state from the main controller.

Comment 9

[Alastor Wu [:alwu]]

Attachment: Bug 1582508 - part8 : add test

Comment 10

[Alastor Wu [:alwu]]

Attachment: Bug 1582508 - part9 : enable wpt 'playbackstate.html'.

Comment 11

[Alastor Wu [:alwu]]

Attachment: Bug 1582508 - part10 : change `MediaSessionPlaybackTestState::None` to `MediaSessionPlaybackTestState::Stopped` to fix the build fail on X11.

On X11, there is an universal definition for None, and it conflicts with the None in the enum of MediaSessionPlaybackTestState, which causes a build fail on X11. Therefore, we have to change its name to avoid using the same name.

[1] from /usr/include/X11/X.h:115
#define None 0L /* universal null resource or null atom */

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c5f84d58424
part1 : implement 'MediaSessionPlaybackState'. r=webidl,chunmin,Ehsan
https://hg.mozilla.org/integration/autoland/rev/cdda4f7b6bf8
part2 : change naming of 'mState' to 'mGuessedPlaybackState' r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a73415e9c006
part3 : create new structure 'MediaSessionInfo' to store the declared playback state for media session. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a008d3cebfdb
part4 : propagate declared playback state to media session controller. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/57a15463a488
part5 : replace 'PlaybackState' with 'MediaSessionPlaybackState'. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/43066b37e9f2
part6 : add actual playback state in the media controller r=chunmin
https://hg.mozilla.org/integration/autoland/rev/0251a2bedd62
part7 : create a chrome-only method to get the playback state from the main controller. r=webidl,Ehsan
https://hg.mozilla.org/integration/autoland/rev/53c2a4fd92df
part8 : add test r=chunmin
https://hg.mozilla.org/integration/autoland/rev/9bd2e656a40e
part9 : enable wpt 'playbackstate.html'. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/bc42a2aec0e4
part10 : change `MediaSessionPlaybackTestState::None` to `MediaSessionPlaybackTestState::Stopped` to fix the build fail on X11. r=webidl,Ehsan,chunmin

Comment 13

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/9c5f84d58424
https://hg.mozilla.org/mozilla-central/rev/cdda4f7b6bf8
https://hg.mozilla.org/mozilla-central/rev/a73415e9c006
https://hg.mozilla.org/mozilla-central/rev/a008d3cebfdb
https://hg.mozilla.org/mozilla-central/rev/57a15463a488
https://hg.mozilla.org/mozilla-central/rev/43066b37e9f2
https://hg.mozilla.org/mozilla-central/rev/0251a2bedd62
https://hg.mozilla.org/mozilla-central/rev/53c2a4fd92df
https://hg.mozilla.org/mozilla-central/rev/9bd2e656a40e
https://hg.mozilla.org/mozilla-central/rev/bc42a2aec0e4

Comment 14

[Eric Shepherd [:sheppy]]

Documentation updated:

• Updated text of https://wiki.developer.mozilla.org/en-US/docs/Web/API/MediaSession/playbackState
• Included in BCD PR 6002