1620077 - Turn on the pref 'dom.media.mediasession.enabled' on Nightly

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Alastor Wu [:alwu]]

We have finished connecting media control keys to media session's action handlers, and close to finish showing media session's metadata on virtual control interface.

So I think it's time to turn on this pref on Nightly in order to gather more feedbacks and catch potential bugs.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1620077 - part1 : Turn on the pref 'dom.media.mediasession.enabled' on Nightly.

Comment 2

[mozbugzilla]

Hi. I've been following and testing this feature, as I'm really looking forward to it.

I have not reported this since the feature seemed work-in-progress, but as of 75.0a1 (2020-03-04), turning on the pref still breaks playback on music.yotube.com. Previously it also threw an error in the console, however this seems to no longer be the case. It looked like the code was not built to support partial implementations. Is this behavior still expected at this point?

Comment 3

[Alastor Wu [:alwu]]

Thank you for telling me that, I can confirm that music.yotube.com didn't work after I enabled media session. I would take a look to see what API they're using which we don't have, in order not to break them after enabling media session.

Comment 4

[Alastor Wu [:alwu]]

Target it on next release cycle because I have to ensure that enabling media session won't break any sites, eg. music.youtube.

Comment 5

[Alastor Wu [:alwu]]

I can confirm that youtube.music can work well after we apply the patches from bug1580623, bug1582508 and bug1582509. So I will enable the pref after those bugs get fixed.

Comment 6

[Alastor Wu [:alwu]]

Ah, sorry I was wrong, we only need the patch from bug1580623, then youtube.music can work well.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/981e37f4d18d
Turn on the pref 'dom.media.mediasession.enabled' on Nightly. r=chunmin

Comment 8

[Andrei Ciure[:aciure]]

Backed out 3 changesets (bug 1620077, bug 1580623) for causing mochitest failures
https://hg.mozilla.org/integration/autoland/rev/bc13649cbfa3ef1da31685275d0c15ac7b121704

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=293577667&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=981e37f4d18dd9845697ad099da0a9d9068c94dd&failure_classification_id=2

Comment 9

[Alastor Wu [:alwu]]

Attachment: Bug 1620077 - part2 : enable MediaSession and MediaMetadata in testing.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0127495e093c
part1 : Turn on the pref 'dom.media.mediasession.enabled' on Nightly. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/e24f1d77c46e
part2 : enable MediaSession and MediaMetadata in testing. r=baku

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0127495e093c
https://hg.mozilla.org/mozilla-central/rev/e24f1d77c46e

Comment 12

[Eric Shepherd [:sheppy]]

Added to https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features.