1580871 - Enable editor mode in DevEdition

Status: VERIFIED FIXED

(DevTools :: Console, task, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Let's get some feedback

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1580871 - Enable editor mode in DevEdition. r=Honza.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4dd5bc10fd86
Enable editor mode in DevEdition. r=Honza.

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4dd5bc10fd86

Comment 4

[:Harald Kirschner :digitarald]

Comment on attachment 9092380 [details]
Bug 1580871 - Enable editor mode in DevEdition. r=Honza.

Beta/Release Uplift Approval Request

• User impact if declined: Developers who see the Scratchpad deprecation warning have no way of trying out the multiline editor mode that the documentation promotes as alternative. Editor mode has been on in Nightly for a while and is being used.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 9092380
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Editor mode is a well-tested feature and so far few and only minor bugs have been found.
• String changes made/needed:

Comment 5

[Liz Henry (:lizzard)]

Comment on attachment 9092380 [details]
Bug 1580871 - Enable editor mode in DevEdition. r=Honza.

Let's try this in dev edition (beta 7).

Comment 6

[Liz Henry (:lizzard)]

Can you suggest a release note?

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/a32faba2e5e6

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Liz Henry (:lizzard) from comment #6)

Can you suggest a release note?

Let's try:

Write snippets of code and Iterate on them faster in the WebConsole with the new multi-line editor mode.
The Enter key acts as a regular key, adding new lines like in a regular editor, and evaluate with Ctrl + Enter (Cmd + Enter on OSX).

how does that look?

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to :Harald Kirschner :digitarald from comment #4)

• List of other uplifts needed: Bug 9092380

What bug number was supposed to be there?

Comment 10

[Cristian Fogel [:cfogel]]

Verified with 71.0a1 (2019-09-15) and 70.0b7(TC_build) on Windows 10, macOS 10.13, Ubuntu 18.04.

Comment 11

[:Harald Kirschner :digitarald]

My bad, 9092380 was the attachment id.

Comment 12

[:Harald Kirschner :digitarald]

:lizzard, when a feature will be only available in dev edition, I assume updating https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/70 is fine?

Comment 13

[:Harald Kirschner :digitarald]

ni? for my last comment

Comment 14

[Liz Henry (:lizzard)]

Sure, that's fine with me.

Comment 15

[:Harald Kirschner :digitarald]

Clearing relnote, initial request is here: https://bugzilla.mozilla.org/show_bug.cgi?id=1519128#c1