Introduce a framework for expanding certerror code to handle neterrors
Categories
(SeaMonkey :: General, task)
Tracking
(seamonkey2.49esr unaffected, seamonkey2.53 fixed, seamonkey2.57esr fixed)
| Tracking | Status | |
|---|---|---|
| seamonkey2.49esr | --- | unaffected |
| seamonkey2.53 | --- | fixed |
| seamonkey2.57esr | --- | fixed |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: SM2.53.1)
Attachments
(1 file, 1 obsolete file)
|
9.59 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
We currently use toolkit's neterror handling which is basic.
This patch ports parts of the following:
- Bug 1240594 - Merge about:neterror and about:certerror UI code
- Bug 1267514 - Fix about:neterror generic fallback text when there is no available title/description for the error
- Bug 989197 - Show alternate UI in cert error pages when a captive portal is active
- Bug 1394462 - Update dnsNotFound error copy and illustration
There should be no visible change to the UI with this patch, it just creates the framework for further enhancement.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: One minor change to one entity.
|
||
Comment 2•7 years ago
|
||
Slight adjustment to how boldness is done
(In reply to Frank-Rainer Grahl (:frg) from comment #2)
Comment on attachment 9093006 [details] [diff] [review]
Add frameworkLGTM. Tested with https://badssl.com/
I am assuming that for Bug 989197 follow-ups are needed?
Yes, that will be a separate bug.
|
|
||
Comment 5•7 years ago
|
||
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/57ed65500348
Introduce a framework for expanding certerror code to handle neterrors. r=frg
|
|
||
Comment 7•7 years ago
|
||
|
|
||
Comment 8•6 years ago
|
||
Description
•