1582489 - [RTL] "Use a Securely Generated Password" (autocomplete="new password") string is not displayed according to RTL design

Status: NEW

(Toolkit :: Password Manager, defect, P3)

Description

[Andrei Purice]

I have tested this issue on Windows 10 64-bit on the beta version of Firefox 70.0b7 and the Nightly one 71.0a1 (2019-09-19).

Steps :

1. Download and instll any RTL build (ar/he).
2. Launch Firefox and reach any sign in page : ex. : https://imgur.com/signin.
3. Using the Dev.Tools (F12) inspect the password field, edit it adding or changing autocomplete ="new-password" and focus away.
4. Click on the password field.

Expected result :
The "Use a Securely Generated Password" string is displayed accordingly for RTL build.

Actual result :
The "Use a Securely Generated Password" is displayed just like it would be on a normal non RTL build.

Please check the attached files for more information.

Comment 1

[Andrei Purice]

Attachment: Autocomplete Use a Securely Generated Password.jpg

Comment 2

[Matthew N. [:MattN]]

This is probably a dupe of bug 1582478 too but I can't tell if there is a problem unless the strings are translated… I imagine that the generated password will be left aligned while the description will be right-aligned once they translate but I don't know if that is what is expected. Maybe Itiel can provide his view?

Comment 3

[Itiel]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #2)

This is probably a dupe of bug 1582478 too but I can't tell if there is a problem unless the strings are translated… I imagine that the generated password will be left aligned while the description will be right-aligned once they translate but I don't know if that is what is expected. Maybe Itiel can provide his view?

Thanks for asking!
I doubt this is related to the fact that the string is not translated there (same in Hebrew btw).
Adding a dir="rtl" to the html header in https://imgur.com/signin makes this issue go away, so this reminds me of bug 1330597, though not sure if to call this a dupe.

Comment 4

[Matthew N. [:MattN]]

Thank you for the pointer.

Comment 5

[Matthew N. [:MattN]]

Not fixing for 70 since this is an existing widespread issue with our autocomplete popups.