1583114 - creating profiles in about:profiles does not work

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect, P1)

Description

[grate]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

When in about:profiles, pressing "Create a New Profile" does not create a new profile

Actual results:

When "Create a New Profile" is pressed, the pop up to make a new profile does not show.

Expected results:

When "Create a New Profile", pop up should have appeared to create a new profile.

Comment 1

[Francesco Lodolo [:flod]]

I can confirm

NS_ERROR_ILLEGAL_VALUE: aboutProfiles.js:211
    createProfileWizard chrome://global/content/aboutProfiles.js:211

Comment 2

[Francesco Lodolo [:flod]]

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=89b9b3aa3aafb413060c61e381723c0788c07848&tochange=19c33f741d779768f53eed13e5c0f45e0363f537

Comment 3

[Francesco Lodolo [:flod]]

[Tracking Requested - why for this release]:
Missing feature in about:profiles should not move to beta

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

Marking as P1 as we broke an end-user feature in 71. Kmag, your patches in bug 1553804 broke this, could you have a look please? Thanks

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1583114: Fix straggling callers which create chrome windows with content openers. r=nika

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8dfe5ab5aba
Fix straggling callers which create chrome windows with content openers. r=nika

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b8dfe5ab5aba

Comment 9

[Cristian Fogel [:cfogel]]

Confirmed issue with 71.0a1 (2019-09-23) on Windows 10.
Fix verified with 71.0b8 on Windows 10, macOS 10.13.6, Ubuntu 18.04.