1586671 - Broken profile creation in about:profiles

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Francesco Lodolo [:flod]]

It looks like bug 1583114 didn't really fix the whole thing.

Create a new profile from about:profiles, at the end the profile won't show up in the list, and the console reports

TypeError: window.opener.CreateProfile is not a function createProfileWizard.js:260:19
    onFinish chrome://mozapps/content/profile/createProfileWizard.js:260
    _fireEvent chrome://global/content/elements/wizard.js:430
    advance chrome://global/content/elements/wizard.js:306
    listeners chrome://global/content/elements/wizard.js:474
    createProfileWizard chrome://global/content/aboutProfiles.js:211

If you refresh the page, the profile will show up, but if you try to start it, it won't work, given that nothing was actually written in profiles.ini

Comment 1

[Dave Townsend [:mossop]]

The way the create profile wizard calls a function on its opener is pretty ugly. If it makes things easier we could figure out a way to clean up the code and not do that.

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1586671: Pass callbacks as openDialog argument to profile creation wizard rather than using window.opener. r=mossop

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f33ba9f39ad0
Pass callbacks as openDialog argument to profile creation wizard rather than using window.opener. r=mossop

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f33ba9f39ad0

Comment 6

[Vlad Lucaci, Desktop QA (:vlucaci)]

Managed to reproduce this issue on 71.0a1(buildID:20191007215350).

Confirming this issue as verified fixed on 71.0b7(buildID:20191104135555) and 72.0a1 (buildID:20191104214406). Verified using Windows 10x64, Ubuntu 18.04 and macOS 10.14.