1583283 - [meta] Megabar + openViewOnFocus is janky

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P5)

Description

[Drew Willcoxon :adw]

Verdi mentioned in the search meeting today that when the megabar is enabled and you're using the top sites experiment extension (i.e., openViewOnFocus is enabled), the view doesn't open until the megabar animation completes. It should open as the animation starts. (Verdi, please correct if I'm not describing this right.)

Comment 1

[Verdi [:verdi] Best to slack me]

The way I've thought about it is that it's not two animations. When I made this prototype, I literally just animated the bar between the regular state and the fully expanded with results state. https://firefox.michaelverdi.com/allinone/ You'll have to tell me what is possible here but this is what I was aiming for.

Comment 2

[Dão Gottwald [:dao]]

(In reply to Drew Willcoxon :adw from comment #0)

[...] the view doesn't open until the megabar animation completes.

Pretty sure this isn't true. None of the urlbar code cares about the animation, it's just CSS transitions. In my testing the view opens pretty much immediately and just animates with the parent urlbar, although we only transition width, left, and padding-inline. I'm not sure that we can use the exact same animation as in verdi's mockup.

Comment 3

[Verdi [:verdi] Best to slack me]

Attachment: animation.mp4

Here's a video of the interaction. It actually happens in 4 parts:

1. Top and bottom padding pops.
2. Sides animate out.
3. Top sites pop out.
4. URL gets selected.

Ideally, nothing would just pop and it would all happen simultaneously.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Verdi [:verdi] NI or PM me from comment #3)

Created attachment 9095323 [details]
animation.mp4

Here's a video of the interaction. It actually happens in 4 parts:

1. Top and bottom padding pops.

I tried to animate the vertical growing but that made the text jerk vertically. I'm not sure if there's a way around that.

2. Sides animate out.
3. Top sites pop out.

If you look closely at your slowed down video, you'll see that the animation is still ongoing when the results pop up. It just so happens that on your system these things seem to correlate, but they're strictly independent and will happen simultaneously as long as we get results quickly enough.

Comment 5

[Marco Bonardo [:mak]]

We should get a new evaluation by Verdi. Now the animation is shorter, and the selection happens at the same time as the animation.
If the situation is good enough, we may close this.

I don't think we can make the results view animate at a wanted time, because there's no way to predict incoming results behavior, unless we want to open an empty panel and then grow it (not sure how hard that would be). Apart from the openViewOnFocus case, this is likely to also affect retained results.

Comment 6

[Mike de Boer [:mikedeboer]]

I've done an evaluation yesterday with Verdi and I'd like to discuss a couple of things with the team as a result (Dão, Harry and you) this Friday.

Comment 7

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

This behavior is no longer accurate, can we change the resolution of this issue?

Comment 8

[Dão Gottwald [:dao]]

(In reply to Cristian Comorasu, QA [:ccomorasu], Release Desktop QA from comment #7)

This behavior is no longer accurate, can we change the resolution of this issue?

What do you mean? This is a meta bug and we closed it as the original concerns have been addressed in the bugs blocking this one. There may be more room for improvement and people should feel free to file new bugs to that end.