Closed Bug 1583285 Opened 7 years ago Closed 7 years ago

Please remove Web Compat 6.0.3 from Balrog (and replace it with 6.1.0)

Categories

(Firefox :: System Add-ons: Off-train Deployment, defect)

Product:
Firefox
Component:
System Add-ons: Off-train Deployment
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: twisniewski, Unassigned)

References

Details

Attachments

(4 files)

webcompat-6.1.0.unsigned.xpi
41.01 KB, application/x-xpinstall
Details
signed.9094657.xpi
51.95 KB, application/x-xpinstall
Details
BrowserConsoleLogs.jpg
274.15 KB, image/jpeg
Details
About_SupportData.txt
19.82 KB, text/plain
Details

We have 6.0.3 shipping now, but need to ship 6.1.0 to address a regression on GMail mobile and add extra site patches.

Flags: needinfo?(wezhou)

(once we have a signed XPI for testing, I'll ping QA)

Attached file signed.9094657.xpi —

Signed file attached. Please test.

Flags: needinfo?(wezhou)

Rehan, can we stage the XPI to the test-channel please?

Flags: needinfo?(rdalal)

(reaching out to QA via email)

This has been staged on the test channel (release-sysaddon) and is pending relman sign off on the live release channel.

Once QA is happy you can request relman sign-off.

Flags: needinfo?(rdalal)
See Also: → 1583225

Mike, I've tested the issues on Firefox Release with the signed add-on and below are my results:

[Environment]
Browser / Version: Firefox Release 69.0.1
Operating System: Windows 10 Pro, MacOS 10.14.6, Huawei P20 Lite (Android 8.0.0) - 1080 x 2280 pixels, 19:9 ratio (~432 ppi density)
Installed add-on: signed.9094657.xpi (webcompat@mozilla.org-6.1.0-signed.xpi - https://aus5.mozilla.org/update/3/SystemAddons/68.0/20190705220548/Darwin_x86_64-gcc3/en-US/release-sysaddon/Darwin%2018.6.0/default/default/update.xml)
Updated channel in the "channel-pref.js" file: pref("app.update.channel", "release-sysaddon");

Thank you, Oana!

Ryan, can we get Relman signoff in the release channel? QA has signed off in Comment #6. I'll send an intent to ship email in a bit to release-drivers.

edit: intent to ship sent.

Flags: needinfo?(ryanvm)

I'm confused, the only rule I see pending signoff in Balrog is for Version <69.0 (rule #907). Shouldn't there be a rule for 69.* too?

Flags: needinfo?(ryanvm)
Flags: needinfo?(rdalal)

@Oana did you install the signed add-on manually? we should be verifying that the update is applied automatically as per: https://gist.github.com/rehandalal/91ccb626dbbe8b58f5e4975567f5eca2

@Ryan We have only been shipping webcompat 6.0.3 to 68.* so I assumed (since no version targeting was mentioned) that we were doing the same here.

Flags: needinfo?(rdalal)
Flags: needinfo?(oana.arbuzov)
Flags: needinfo?(miket)

It should be for 68+, apologies for not being clear. 68 so we pull in Fennec, and 69 for Desktop.

Flags: needinfo?(miket)

I have staged this on the test channel (release-sysaddon) for 69.* and it is pending relman sign off on the live release channel.

QA should verify this on 68 and 69 (fennec and desktop) without installing manually (https://gist.github.com/rehandalal/91ccb626dbbe8b58f5e4975567f5eca2) before relman sign off.

Attached image BrowserConsoleLogs.jpg —

Force auto-update - browser console logs

Flags: needinfo?(oana.arbuzov)
Attached file About_SupportData.txt —

About:support data

Rehan, I followed the instructions you provided here (https://gist.github.com/rehandalal/91ccb626dbbe8b58f5e4975567f5eca2), but the add-on does not seem to be available.
And another thing shouldn't there be an older add-on installed in order to force an auto-update?

I've tested with fresh profile of Firefox Release 69.0.1.

I've attached the browser console logs and the data from about:support.

Flags: needinfo?(rdalal)

Rehan, I followed the instructions you provided here (https://gist.github.com/rehandalal/91ccb626dbbe8b58f5e4975567f5eca2), but the add-on does not seem to be available.

Based on the screenshot and the about:support data you posted, the update channel was not set to release-sysaddon as expected. This is why you did not receive the update.

Did you modify defaults/pref/channel-prefs.js? I also realized the instructions did not mention that this should be modified while the browser is not loaded and then start up the browser after the change or it will not apply.

And another thing shouldn't there be an older add-on installed in order to force an auto-update?

The older add-on is already built in to the browser.

Flags: needinfo?(rdalal) → needinfo?(oana.arbuzov)

I made it work on Mac and checked all desktop issues with the force auto-update add-on. I will give it another try tomorrow for Windows. Thanks for the extra info.

[Environment]
Browser / Version: Firefox Release 69.0.1
Operating System: MacOS 10.14.6
about:support > Firefox Features > Web Compat version 6.1.0

Flags: needinfo?(oana.arbuzov)

OK, Ryan seems like we're good -- can we get relman signoff in Balrog?

Flags: needinfo?(ryanvm)

Signed off and confirmed live on Balrog.

Flags: needinfo?(ryanvm)

Thanks all! Let's close here.

Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED

Another try and it finally worked on Windows too. So I added the tests results:

supportforms.embarcadero.com
[Fixed - desktop - windows] https://webcompat.com/issues/34682
steamcommunity.com
[Fixed - desktop - windows] https://webcompat.com/issues/34171
apply.lloydsbank.co.uk
[Fixed - desktop - windows] https://webcompat.com/issues/34969
dunkindonuts.com
[Fixed - desktop - windows] https://webcompat.com/issues/28742

[Environment]
Browser / Version: Firefox Release 69.0.1
Operating System: Windows 10 Pro
about:support > Firefox Features > Web Compat version 6.1.0

Thanks all!

See Also: → 1587186
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: