Closed Bug 1583430 Opened 4 months ago Closed 3 months ago

No-sampling profiling follow-up: Show "nostacksampling" feature in popup

Categories

(Core :: Gecko Profiler, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

Details

Attachments

(1 file)

Bug 1549482 turns off stack samples when all of ("stackwalk", "leaf", "js") are off.

This means it is not possible to record label-only stacks anymore.
Also, this is a bit hidden from users.

We should consider how to better expose this no-sampling mode, possibly with a new feature, and/or help from the popup.

Bug 1583868 makes the change to an explicit feature "nostacksampling".

I'll keep this bug here to update the popup.

Depends on: 1583868
Summary: No-sampling profiling follow-up: Separate explicit feature → No-sampling profiling follow-up: Show "nostacksampling" feature in popup
No longer blocks: 1583431

To do as well: Write documentation in https://profiler.firefox.com/docs/

Assignee: nobody → gsquelart
Attachment #9101180 - Attachment description: Bug 1583430 - Profiler popup feature "No Stack Sampling" - r?gregtatum → Bug 1583430 - Profiler popup feature "Periodic Sampling" (enabled by default) - r?gregtatum
Attachment #9101180 - Attachment description: Bug 1583430 - Profiler popup feature "Periodic Sampling" (enabled by default) - r?gregtatum → Bug 1583430 - Profiler popup feature "No Periodic Sampling" - r?gregtatum
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/155bea712008
Profiler popup feature "No Periodic Sampling" - r=julienw
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.