1583430 - No-sampling profiling follow-up: Show "nostacksampling" feature in popup

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Bug 1549482 turns off stack samples when all of ("stackwalk", "leaf", "js") are off.

This means it is not possible to record label-only stacks anymore.
Also, this is a bit hidden from users.

We should consider how to better expose this no-sampling mode, possibly with a new feature, and/or help from the popup.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Bug 1583868 makes the change to an explicit feature "nostacksampling".

I'll keep this bug here to update the popup.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

To do as well: Write documentation in https://profiler.firefox.com/docs/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1583430 - Profiler popup feature "No Periodic Sampling" - r?gregtatum

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/155bea712008
Profiler popup feature "No Periodic Sampling" - r=julienw

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/155bea712008