1583431 - No-sampling profiling follow-up: Write regression test for "nostacksampling"

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Bug 1549482 introduced a no-sampling mode.
Manual testing showed that it's not producing stack traces as expected, which should be good enough for early adopters.

It would be good to write a proper regression test that inspects the output json to verify that no samples are produced.

Bug 1583430 may change the way the no-sampling mode is triggered, which may influence this test.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Bug 1583868 adds an explicit "nostacksampling" feature, which we want to test.

(Bug 1583430 will now focus on the popup, so it's independent from this test.)

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1583431 - stopProfilerNowAndGetThreads doesn't wait for samples - r?gregtatum

stopProfilerAndGetThreads() waits until at least one sample appears in the
main thread, before capturing a profile and stopping the profiler.

stopProfilerNowAndGetThreads() does not wait; this should be useful in tests
that may not generate any samples (e.g., using the nostacksampling feature).

Depends on D49231

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1583431 - Don't wait for samples in marker-only tests - r?gregtatum

Depends on D49232

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1583431 - Test "No Stack Sampling" feature - r?gregtatum

Depends on D49233

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a48c7ca0561f
stopProfilerNowAndGetThreads doesn't wait for samples - r=julienw
https://hg.mozilla.org/integration/autoland/rev/fd3fd026545e
Don't wait for samples in marker-only tests - r=gregtatum,julienw
https://hg.mozilla.org/integration/autoland/rev/0acc43751420
Test "No Stack Sampling" feature - r=julienw

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a48c7ca0561f
https://hg.mozilla.org/mozilla-central/rev/fd3fd026545e
https://hg.mozilla.org/mozilla-central/rev/0acc43751420