Closed Bug 1583444 Opened 6 months ago Closed 6 months ago

Check remaining occurrences of window.top that might fail with content frame

Categories

(DevTools :: General, task, P1)

task

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission dt-fission-m1)

Attachments

(4 files)

After Bug 1539979, the DevTools toolbox runs in a content frame.
One of the consequences is that we can no longer reach the topmost chrome frame using window.top.

We fixed all the spots that were detected by test failures, but there are probably other areas that are not tested but rely on window.top as well.
We recently had the following regression in the performance panel: https://bugzilla.mozilla.org/show_bug.cgi?id=1578373

The goal of this bug is to be more proactive and try to identify other potential regressions and fix them as soon as possible.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: -- → P1
See Also: → 1583457

Depends on D46959
For those tests, using win.top was the same as using win, and did not have any impact on the asserts performed in the test.
We could have left them around, but for completeness I prefer to remove them as well.

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4dca3917f04
Stop using window.top in WebConsole codebase r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/6f09a19d3fa4
Stop using win.top in devtools/shared/layout/utils.js r=pbro
https://hg.mozilla.org/integration/autoland/rev/a7bbb75ce721
Reuse DevToolsUtils.getTopWindow in HTMLTooltip r=yzen
https://hg.mozilla.org/integration/autoland/rev/c62a28520dd6
Stop using win.top in DevTools tests r=nchevobbe
Whiteboard: dt-fission → dt-fission dt-fission-m1
You need to log in before you can comment on or make changes to this bug.