1583708 - Intermittent browser/components/urlbar/tests/browser/browser_urlbar_collapseOnChromeMousedown.js | The Urlbar should have the breakout-extend attribute. - false == true - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: malexandru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=268266365&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/Ht_DkC7CSGuuu_Tz5b0NqA/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/Ht_DkC7CSGuuu_Tz5b0NqA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2019-09-24T23:59:07.237Z] 23:59:07 INFO - TEST-START | browser/components/urlbar/tests/browser/browser_urlbar_collapseOnChromeMousedown.js
[task 2019-09-24T23:59:07.563Z] 23:59:07 INFO - GECKO(1161) | ++DOCSHELL 0x7f299cd56800 == 7 [pid = 1161] [id = {1a0c0fe7-9f1c-4712-a52b-747ba6a10e95}]
[task 2019-09-24T23:59:07.563Z] 23:59:07 INFO - GECKO(1161) | ++DOMWINDOW == 15 (0x7f29a1347880) [pid = 1161] [serial = 15] [outer = (nil)]
[task 2019-09-24T23:59:07.564Z] 23:59:07 INFO - GECKO(1161) | ++DOMWINDOW == 16 (0x7f299ac80800) [pid = 1161] [serial = 16] [outer = 0x7f29a1347880]
[task 2019-09-24T23:59:07.604Z] 23:59:07 INFO - GECKO(1161) | [Parent 1161, Main Thread] WARNING: Attempting to get a displayport from a content with no primary frame!: file /builds/worker/workspace/build/src/layout/base/nsLayoutUtils.cpp, line 767
[task 2019-09-24T23:59:07.605Z] 23:59:07 INFO - GECKO(1161) | [Parent 1161, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 416
[task 2019-09-24T23:59:07.767Z] 23:59:07 INFO - GECKO(1161) | ++DOCSHELL 0x7f299cd51000 == 8 [pid = 1161] [id = {3da1742a-0280-4b8c-a2e3-68a9e7d2d192}]
[task 2019-09-24T23:59:07.768Z] 23:59:07 INFO - GECKO(1161) | ++DOMWINDOW == 17 (0x7f29a1347a60) [pid = 1161] [serial = 17] [outer = (nil)]
[task 2019-09-24T23:59:07.848Z] 23:59:07 INFO - GECKO(1161) | ++DOCSHELL 0x7f299767f000 == 9 [pid = 1161] [id = {f240fa74-ed45-4224-966d-1fe1d8bd5c9b}]
[task 2019-09-24T23:59:07.851Z] 23:59:07 INFO - GECKO(1161) | ++DOMWINDOW == 18 (0x7f29a1347c40) [pid = 1161] [serial = 18] [outer = (nil)]
[task 2019-09-24T23:59:08.010Z] 23:59:08 INFO - GECKO(1161) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpd04YMs.mozrunner/runtests_leaks_tab_pid1334.log
[task 2019-09-24T23:59:08.189Z] 23:59:08 INFO - GECKO(1161) | ++DOMWINDOW == 19 (0x7f29972a0000) [pid = 1161] [serial = 19] [outer = 0x7f29a1347a60]
[task 2019-09-24T23:59:08.190Z] 23:59:08 INFO - GECKO(1161) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-09-24T23:59:08.199Z] 23:59:08 INFO - GECKO(1161) | ++DOMWINDOW == 20 (0x7f29972a0c00) [pid = 1161] [serial = 20] [outer = 0x7f29a1347c40]
[task 2019-09-24T23:59:08.356Z] 23:59:08 INFO - GECKO(1161) | ++DOCSHELL 0x7f5a996b2000 == 1 [pid = 1334] [id = {3818f0c0-2410-44c7-8f5f-b34723713a20}]
[task 2019-09-24T23:59:08.420Z] 23:59:08 INFO - GECKO(1161) | ++DOMWINDOW == 1 (0x7f5a9a5c2f20) [pid = 1334] [serial = 1] [outer = (nil)]
[task 2019-09-24T23:59:08.424Z] 23:59:08 INFO - GECKO(1161) | ++DOMWINDOW == 2 (0x7f5a99632c00) [pid = 1334] [serial = 2] [outer = 0x7f5a9a5c2f20]
[task 2019-09-24T23:59:08.626Z] 23:59:08 INFO - GECKO(1161) | ++DOMWINDOW == 3 (0x7f5a99f7a800) [pid = 1334] [serial = 3] [outer = 0x7f5a9a5c2f20]
[task 2019-09-24T23:59:08.682Z] 23:59:08 INFO - GECKO(1161) | [Parent 1161, Main Thread] WARNING: Ignoring duplicate observer.: file /builds/worker/workspace/build/src/modules/libpref/Preferences.cpp, line 2696
[task 2019-09-24T23:59:08.768Z] 23:59:08 INFO - GECKO(1161) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpd04YMs.mozrunner/runtests_leaks_tab_pid1361.log
[task 2019-09-24T23:59:08.925Z] 23:59:08 INFO - GECKO(1161) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-09-24T23:59:09.006Z] 23:59:09 INFO - GECKO(1161) | ++DOCSHELL 0x7f2997333000 == 10 [pid = 1161] [id = {d0321cdd-8825-47da-b56a-c854b48e31c1}]
[task 2019-09-24T23:59:09.008Z] 23:59:09 INFO - GECKO(1161) | ++DOMWINDOW == 21 (0x7f29976bbf20) [pid = 1161] [serial = 21] [outer = (nil)]
[task 2019-09-24T23:59:09.010Z] 23:59:09 INFO - GECKO(1161) | ++DOMWINDOW == 22 (0x7f2997227800) [pid = 1161] [serial = 22] [outer = 0x7f29976bbf20]
[task 2019-09-24T23:59:09.042Z] 23:59:09 INFO - GECKO(1161) | [Parent 1161, Main Thread] WARNING: Attempting to get a displayport from a content with no primary frame!: file /builds/worker/workspace/build/src/layout/base/nsLayoutUtils.cpp, line 767
[task 2019-09-24T23:59:09.044Z] 23:59:09 INFO - GECKO(1161) | [Parent 1161, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 416
[task 2019-09-24T23:59:09.187Z] 23:59:09 INFO - GECKO(1161) | ++DOCSHELL 0x7f2997695000 == 11 [pid = 1161] [id = {6fde63bb-4fa0-4b60-b4a5-dc307ca7d7fc}]
[task 2019-09-24T23:59:09.188Z] 23:59:09 INFO - GECKO(1161) | ++DOMWINDOW == 23 (0x7f29976bc100) [pid = 1161] [serial = 23] [outer = (nil)]
[task 2019-09-24T23:59:09.243Z] 23:59:09 INFO - GECKO(1161) | ++DOCSHELL 0x7f29971e3000 == 12 [pid = 1161] [id = {761b0921-8fa5-4880-87b8-51a4820a2d2f}]
[task 2019-09-24T23:59:09.244Z] 23:59:09 INFO - GECKO(1161) | ++DOMWINDOW == 24 (0x7f29976bc2e0) [pid = 1161] [serial = 24] [outer = (nil)]
[task 2019-09-24T23:59:09.364Z] 23:59:09 INFO - GECKO(1161) | ++DOCSHELL 0x7f85e98b0800 == 1 [pid = 1361] [id = {cb4b51d1-471a-4b45-ac73-7323f06e0eab}]
[task 2019-09-24T23:59:09.425Z] 23:59:09 INFO - GECKO(1161) | ++DOMWINDOW == 1 (0x7f85e9819f20) [pid = 1361] [serial = 1] [outer = (nil)]
[task 2019-09-24T23:59:09.425Z] 23:59:09 INFO - GECKO(1161) | ++DOMWINDOW == 2 (0x7f85e982f800) [pid = 1361] [serial = 2] [outer = 0x7f85e9819f20]
[task 2019-09-24T23:59:09.501Z] 23:59:09 INFO - GECKO(1161) | ++DOMWINDOW == 25 (0x7f299775d800) [pid = 1161] [serial = 25] [outer = 0x7f29976bc100]
[task 2019-09-24T23:59:09.516Z] 23:59:09 INFO - GECKO(1161) | ++DOMWINDOW == 26 (0x7f299775f000) [pid = 1161] [serial = 26] [outer = 0x7f29976bc2e0]
[task 2019-09-24T23:59:09.642Z] 23:59:09 INFO - GECKO(1161) | ++DOMWINDOW == 3 (0x7f85e9eb0400) [pid = 1361] [serial = 3] [outer = 0x7f85e9819f20]
[task 2019-09-24T23:59:09.690Z] 23:59:09 INFO - GECKO(1161) | [Parent 1161, Main Thread] WARNING: Ignoring duplicate observer.: file /builds/worker/workspace/build/src/modules/libpref/Preferences.cpp, line 2696
[task 2019-09-24T23:59:09.791Z] 23:59:09 INFO - GECKO(1161) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpd04YMs.mozrunner/runtests_leaks_tab_pid1386.log
[task 2019-09-24T23:59:09.960Z] 23:59:09 INFO - GECKO(1161) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-09-24T23:59:10.029Z] 23:59:10 INFO - TEST-INFO | started process screentopng
[task 2019-09-24T23:59:10.714Z] 23:59:10 INFO - TEST-INFO | screentopng: exit 0
[task 2019-09-24T23:59:10.715Z] 23:59:10 INFO - Buffered messages logged at 23:59:07
[task 2019-09-24T23:59:10.716Z] 23:59:10 INFO - Entering test bound
[task 2019-09-24T23:59:10.717Z] 23:59:10 INFO - Buffered messages logged at 23:59:08
[task 2019-09-24T23:59:10.717Z] 23:59:10 INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_urlbar_collapseOnChromeMousedown.js | The Urlbar should have the breakout-extend attribute. - true == true -
[task 2019-09-24T23:59:10.718Z] 23:59:10 INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_urlbar_collapseOnChromeMousedown.js | The Urlbar should have the breakout-extend attribute. - true == true -
[task 2019-09-24T23:59:10.720Z] 23:59:10 INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_urlbar_collapseOnChromeMousedown.js | The Urlbar should not have the breakout-extend attribute. - true == true -
[task 2019-09-24T23:59:10.720Z] 23:59:10 INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_urlbar_collapseOnChromeMousedown.js | The Urlbar should be focused. - true == true -
[task 2019-09-24T23:59:10.720Z] 23:59:10 INFO - Buffered messages finished
[task 2019-09-24T23:59:10.720Z] 23:59:10 INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_urlbar_collapseOnChromeMousedown.js | The Urlbar should have the breakout-extend attribute. - false == true - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_urlbar_collapseOnChromeMousedown.js :: <TOP_LEVEL> :: line 43
[task 2019-09-24T23:59:10.720Z] 23:59:10 INFO - Stack trace:
[task 2019-09-24T23:59:10.720Z] 23:59:10 INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_urlbar_collapseOnChromeMousedown.js:null:43
[task 2019-09-24T23:59:10.720Z] 23:59:10 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1350
[task 2019-09-24T23:59:10.720Z] 23:59:10 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1385
[task 2019-09-24T23:59:10.720Z] 23:59:10 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1207
[task 2019-09-24T23:59:10.721Z] 23:59:10 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-09-24T23:59:10.722Z] 23:59:10 INFO - Leaving test bound
[task 2019-09-24T23:59:10.723Z] 23:59:10 INFO - GECKO(1161) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2019-09-24T23:59:10.723Z] 23:59:10 INFO - GECKO(1161) | MEMORY STAT | vsize 2901MB | residentFast 414MB | heapAllocated 181MB
[task 2019-09-24T23:59:10.724Z] 23:59:10 INFO - TEST-OK | browser/components/urlbar/tests/browser/browser_urlbar_collapseOnChromeMousedown.js | took 2946ms

Comment 1

[Cristina Coroiu [:ccoroiu]]

Tier1 failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=268349292&repo=try&lineNumber=6961

Comment 2

[Harry Twyford]

I believe this isn't an issue with the test itself, but some new behaviour introduced in bug 1583495. 1583495 landed right after bug 1579004. There is a fix underway in bug 1583993, which will fix this test failure.

Comment 3

[Intermittent Failures Robot]

21 failures in 870 pushes (0.024 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 14
• mozilla-central: 3
• oak: 1
• try: 2
• mozilla-inbound: 1

Platform breakdown:

• linux64-shippable: 19
• linux64: 1
• linux64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1583708&startday=2019-09-26&endday=2019-09-26&tree=all

Comment 4

[Intermittent Failures Robot]

18 failures in 850 pushes (0.021 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 12
• mozilla-central: 2
• try: 4

Platform breakdown:

• linux64-shippable: 14
• linux64: 2
• linux64-devedition: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1583708&startday=2019-09-27&endday=2019-09-27&tree=all

Comment 5

[Intermittent Failures Robot]

66 failures in 4530 pushes (0.015 failures/push) were associated with this bug in the last 7 days.

This is the #19 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 40
• mozilla-central: 11
• try: 13
• oak: 1
• mozilla-inbound: 1

Platform breakdown:

• linux64: 7
• linux64-shippable: 52
• linux64-ccov: 1
• linux64-devedition: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1583708&startday=2019-09-23&endday=2019-09-29&tree=all

Comment 6

[Intermittent Failures Robot]

20 failures in 820 pushes (0.024 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 11
• mozilla-inbound: 1
• try: 6
• mozilla-central: 2

Platform breakdown:

• linux64-shippable: 14
• linux64-devedition: 2
• linux64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1583708&startday=2019-09-30&endday=2019-09-30&tree=all

Comment 7

[Dão Gottwald [:dao]]

Judging by the latest failures, bug 1583993 didn't fix this, and thus bug 1583495 probably didn't cause this in the first place?

Comment 8

[Harry Twyford]

Looks like this is broken because of the what UrlbarInput events are called when a window is refocused. It works like this:

STR

1. Focus the Urlbar.
2. Click out of the Firefox window.
3. Refocus the window by clicking somewhere on the page content.

On Windows and Mac, the Urlbar refocuses (when Megabar is enabled, it also expands). On Linux, the Urlbar is not refocused. This is true when the Megabar pref is turned off as well. Possibly related: on Windows and Mac, only the UrlbarInput._on_focus event is called in this case. On Linux, UrlbarInput._on_focus is followed by UrlbarInput._on_mousedown. This means that one part of browser_urlbar_collapseOnChromeMousedown.js that tests that behaviour specifically will break on Linux.

Dao, do you know if this behaviour on Linux is a feature or a bug? If a feature, I'll just disable this part of the test on Linux. If a bug, the fix may be more complex than simply revising bug 1583993/bug 1579004.

Comment 9

[Intermittent Failures Robot]

26 failures in 930 pushes (0.028 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 19
• try: 6
• mozilla-inbound: 1

Platform breakdown:

• linux64-shippable: 22
• linux64: 3
• linux64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1583708&startday=2019-10-02&endday=2019-10-02&tree=all

Comment 10

[Intermittent Failures Robot]

17 failures in 824 pushes (0.021 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 4
• autoland: 10
• try: 2
• mozilla-inbound: 1

Platform breakdown:

• linux64: 3
• linux64-shippable: 13
• linux64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1583708&startday=2019-10-03&endday=2019-10-03&tree=all

Comment 11

[Intermittent Failures Robot]

17 failures in 619 pushes (0.027 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 13
• try: 4

Platform breakdown:

• linux64-shippable: 15
• linux64-devedition: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1583708&startday=2019-10-04&endday=2019-10-04&tree=all

Comment 12

[Intermittent Failures Robot]

18 failures in 196 pushes (0.092 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 6
• mozilla-central: 10
• try: 2

Platform breakdown:

• linux64-shippable: 8
• linux64: 9
• linux64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1583708&startday=2019-10-05&endday=2019-10-05&tree=all

Comment 13

[Dão Gottwald [:dao]]

(In reply to Harry Twyford [:harry] from comment #8)

1. Focus the Urlbar.
2. Click out of the Firefox window.
3. Refocus the window by clicking somewhere on the page content.

On Windows and Mac, the Urlbar refocuses (when Megabar is enabled, it also expands). On Linux, the Urlbar is not refocused. This is true when the Megabar pref is turned off as well. Possibly related: on Windows and Mac, only the UrlbarInput._on_focus event is called in this case. On Linux, UrlbarInput._on_focus is followed by UrlbarInput._on_mousedown. This means that one part of browser_urlbar_collapseOnChromeMousedown.js that tests that behaviour specifically will break on Linux.

Dao, do you know if this behaviour on Linux is a feature or a bug? If a feature, I'll just disable this part of the test on Linux. If a bug, the fix may be more complex than simply revising bug 1583993/bug 1579004.

This is expected behavior on Linux. Contrary to what you said it's also both expected and actual behavior on Windows unless I'm missing something.

Comment 14

[Intermittent Failures Robot]

122 failures in 4292 pushes (0.028 failures/push) were associated with this bug in the last 7 days.

This is the #8 most frequent failure this week.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 77
• mozilla-inbound: 4
• try: 21
• mozilla-central: 20

Platform breakdown:

• linux64-shippable: 93
• linux64-devedition: 6
• linux64: 23

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1583708&startday=2019-09-30&endday=2019-10-06&tree=all

Comment 15

[Harry Twyford]

Attachment: Bug 1583708 - Disable failing part of browser_urlbar_collapseOnChromeMousedown.js. r?dao

Comment 16

[Harry Twyford]

Verdi is still thinking over how window-switching behaviour should work for the Megabar, so I'm removing the part of the test that's failing while that's being decided.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91bec74c770a
Disable failing part of browser_urlbar_collapseOnChromeMousedown.js. r=dao

Comment 18

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/91bec74c770a

Comment 19

[Intermittent Failures Robot]

18 failures in 677 pushes (0.027 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 10
• mozilla-central: 3
• mozilla-inbound: 1
• try: 4

Platform breakdown:

• linux64-shippable: 14
• linux64: 3
• linux64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1583708&startday=2019-10-07&endday=2019-10-07&tree=all

Comment 21

[Intermittent Failures Robot]

18 failures in 3801 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 10
• mozilla-central: 3
• try: 4
• mozilla-inbound: 1

Platform breakdown:

• linux64-shippable: 14
• linux64: 3
• linux64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1583708&startday=2019-10-07&endday=2019-10-13&tree=all

Comment 22

[Intermittent Failures Robot]

1 failures in 4182 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• linux64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1583708&startday=2019-10-21&endday=2019-10-27&tree=all