Closed Bug 1584188 Opened 2 years ago Closed 1 year ago

New Fennec Core Ping Fields

Categories

(Firefox for Android Graveyard :: Metrics, enhancement, P1)

ARM
Android
enhancement

Tracking

(firefox-esr6871+ verified)

VERIFIED FIXED
Tracking Status
firefox-esr68 71+ verified

People

(Reporter: st3fan, Assigned: andrei.a.lazar)

References

Details

(Whiteboard: [fennec68.3])

Now that we have a data review confirmed for bug https://bugzilla.mozilla.org/show_bug.cgi?id=1579196 let's implement these new probes.

The fields and the format we want is described in this document:

https://docs.google.com/document/d/1BCjlx8Rl5Sc_sQvbxr1A2w9k4GKT4oId9LfdETL8la4/edit

The goal is to add these to the Core Ping.

My suggestion is to add all of these in bulk in one patch for this bug. Unless we think that is not practical.

Priority: -- → P1
Whiteboard: [fennec68.1.1]

Note that we do not have a sign off on sending add-on IDs just yet, so lets not go there already.

See Also: → 1584194
Assignee: nobody → andrei.a.lazar

Would be great if we could get a description for all of this new fields.
We would then add it to the other ping fields documentation - https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/docs/data/core-ping.rst
And would also help us greatly in knowing exactly what new data we need to collect.

I will start documenting these fields in a bit more detail in the google doc for now. When the work has settled down we should definitely move the descriptions to core-ping.rst.

We updated https://docs.google.com/document/d/1BCjlx8Rl5Sc_sQvbxr1A2w9k4GKT4oId9LfdETL8la4 with a FIeld Details section that is similar to how we documented the rest of the ping.

If there are any questions about any of these fields please comment in the google doc.

Maybe it is a good idea to break up the work in a similar way the fennec.* fields are grouped?

Just a confirmation that we decided to not file individual bugs and simply group the patches under this bug.

Flags: needinfo?(petru.lingurar)
Depends on: 1586302
Depends on: 1586303
Depends on: 1586307
Depends on: 1586308
Depends on: 1586309
Depends on: 1586310
Depends on: 1586311
Depends on: 1586312
Depends on: 1586313

Following the discussion with Stefan we took to break the pings into smaller chunks that are to be added separately so to give time to the data scientists to review each new new fields category.
To make sure we'll adhere to the specifications the first patch will add all fields with default values (the schema structure with stub values) and will be followed with subsequent patches for each fields category.

Flags: needinfo?(petru.lingurar)
Whiteboard: [fennec68.1.1] → [fennec68.2.x]
Whiteboard: [fennec68.2.x] → [fennec68.2.2]

Andrei, I noticed these patches landed and then were backed out, are you still planning to land them again next week for Fennec 68.3?

Flags: needinfo?(andrei.a.lazar)

Hey Liz, working on some last minute fixes. Planning to request uplift again by the end of the week.

Flags: needinfo?(andrei.a.lazar)

Hi, received today new try build for Core Ping, testing based on Firefox 68.3.0 esr.
Build download.
I could not check the values through redash.

@Andrei, could you please look why the values are not displayed at redash level? I will put NI on you, thanks.
Screenshot

Flags: needinfo?(andrei.a.lazar)
Flags: needinfo?(andrei.a.lazar)
Whiteboard: [fennec68.2.2] → [fennec68.3]
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Hi, verified with Google Pixel 3a (Android 9) on Firefox Nightly 68.3a1 (2019-11-25) through redash, with the structure mentioned in the provided documentation.

Hi, I will set this as verified as the other new ping is treated in bug1583525

Status: RESOLVED → VERIFIED
OS: Unspecified → Android
Hardware: Unspecified → ARM
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.