1584501 - [MediaControl-Windows] Implement the SystemMediaTransportControls for Windows

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Marc Streckfuß [:MeFisto94]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

In order to fullfil 1572869, we have to implement the SystemMediaTransportControls.

Unfortunately this is a UWP API, so I don't know how easy we can wire this up, somehow it seems to be possible for non UWP Apps and chromium is also doing it, but they have a lot of abstraction in place.

Comment 1

[Marc Streckfuß [:MeFisto94]]

Attachment: Bug 1584501: Draft Implementation of the Windows SystemMediaTransportControl WinRT Interface

Comment 3

[Alastor Wu [:alwu]]

Hi, Marc, are you still working on this bug and bug 1353652? If not, do you mind I continue your work? Now my plan is that to implement the first version which only supports controlling media without providing metadata, because we haven't finished the part of updating correct media metadata from media session. So I would say to provide the basic information for both SMTC and MPRIS, which is using Firefox as artist name. Then, we would continue to work on providing other infomation later.

Comment 4

[Marc Streckfuß [:MeFisto94]]

Hey Alastor,
Yes I am still working on this bug.
Apologizes for the delay, I had it on my list but got side-tracked, especially thinking that you guys still need to do some background work first. I should've answered the questions, though. I will do that right now, especially if that means we can have media keys working very soon.

Since there might be some webpages not transmitting any Metadata either, I would recommend some kind of title like (Metadata) not available, so that it's clear this is no bug, but that's just a quick idea. The downside would be that localization would be needed and I especially don't know how those APIs perform with Unicode/Non-ASCII.

Anyway, I'll do some refactoring and answering the questions on Phabricator now.

Comment 5

[Alastor Wu [:alwu]]

(In reply to Marc Streckfuß [:MeFisto94] from comment #4)

Since there might be some webpages not transmitting any Metadata either, I would recommend some kind of title like (Metadata) not available, so that it's clear this is no bug, but that's just a quick idea. The downside would be that localization would be needed and I especially don't know how those APIs perform with Unicode/Non-ASCII.

For that kinds of websites, I think we can use its website title as artist name, and its favicon as album cover. But for the first stage, I would like to simply show "Firefox" as artist name on the virtual controller, to indicate where this control come from.

Comment 6

[Marc Streckfuß [:MeFisto94]]

simply show "Firefox" as artist name on the virtual controller, to indicate where this control come from.
With a Firefox logo? If so I'd need an official URL for that. I think it greatly improves "accessability" in that case, you immediately see what you control even without having to read.

Comment 7

[Marc Streckfuß [:MeFisto94]]

On Twitch the current version doesn't work: When Pausing SMTC seems to be gone and thus pressing play again triggers my other media player in the background and manually trying to select Firefox as Player doesn't work. I have to check if there is any Assertion or Logging Output relevant to find out what the problem here is. I also have to check how this is on Linux, this WriteUp is just so I don't forget about it.

Edit: My Preliminary thinking is, that after pausing, the video element is essentially destroyed or replaced by a thumbnail and thus it falls out of the scope of our system.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/647e98de0262
Draft Implementation of the Windows SystemMediaTransportControl WinRT Interface r=alwu

Comment 9

[Dorel Luca [:dluca]]

Backed out changeset 647e98de0262 (bug 1584501) for Build bustage in widget/windows/WindowsSMTCProvider.h. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289599547&repo=autoland&lineNumber=76056

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=289599547&revision=647e98de02629c29b219c4203a49e33270d8e01d

Backout:
https://hg.mozilla.org/integration/autoland/rev/f81c96516a0c58672fc572a210505f3a0a99b814

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3dbd1e653555
Draft Implementation of the Windows SystemMediaTransportControl WinRT Interface r=alwu

Comment 11

[Dorel Luca [:dluca]]

Backed out changeset 3dbd1e653555 (bug 1584501) for WPT failures in widget/windows/WindowsSMTCProvider.cpp

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289625492&repo=autoland&lineNumber=35813

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=3dbd1e653555b1404d47bfe9f4230d91c599ba06

Backout:
https://hg.mozilla.org/integration/autoland/rev/d4ef109d6d5958782a0f0e438ca2e93ae6349b0e

Comment 12

[Marc Streckfuß [:MeFisto94]]

Should be solved when 1616800 is merged.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1721c48538d
Draft Implementation of the Windows SystemMediaTransportControl WinRT Interface r=alwu

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e1721c48538d