1616800 - MediaControl: MediaControlKeysManager does not honor Open() return value

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Marc Streckfuß [:MeFisto94]]

See https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289625492&repo=autoland&lineNumber=35813 for the failure.

Specifically:

if (mEventSource && !mEventSource->IsOpened()) {
    LOG("StartMonitoringControlKeys");
    mEventSource->Open();
    mEventSource->SetPlaybackState(mPlaybackState);
    mEventSource->AddListener(this);
  }

The return value of Open() is ignored, however Open() fails on Windows 7 and below.

Comment 1

[Marc Streckfuß [:MeFisto94]]

Attachment: Bug 1616800 - MediaControl: MediaControlKeysManager now checks the result of EventSource#Open(). r=alwu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af8c6e426074
MediaControl: MediaControlKeysManager now checks the result of EventSource#Open(). r=alwu

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/af8c6e426074