Closed Bug 1616800 Opened 4 years ago Closed 4 years ago

MediaControl: MediaControlKeysManager does not honor Open() return value

Categories

(Core :: Audio/Video, defect, P1)

Desktop
Windows 7
defect

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: MeFisto94, Assigned: MeFisto94)

References

Details

Attachments

(1 file)

See https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289625492&repo=autoland&lineNumber=35813 for the failure.

Specifically:

if (mEventSource && !mEventSource->IsOpened()) {
    LOG("StartMonitoringControlKeys");
    mEventSource->Open();
    mEventSource->SetPlaybackState(mPlaybackState);
    mEventSource->AddListener(this);
  }

The return value of Open() is ignored, however Open() fails on Windows 7 and below.

Pushed by marc.streckfuss@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/af8c6e426074
MediaControl: MediaControlKeysManager now checks the result of EventSource#Open(). r=alwu
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: