1584511 - [Wayland][WebRender] Toggling titlebar breaks remote content rendering for existing tabs

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Kestrel]

Attachment: Spinner after toggling titlebar

STR.

1. Enable gfx.webrender.all and MOZ_ENABLE_WAYLAND=true on Ubuntu 19.04.
2. Visit a website.
3. Go into Customize and toggle the titlebar.

Content rendering breaks for existing tabs, shows permanent spinning wheel. New tabs unaffected.

Not a regression and reproducible back to Bug 1531300.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jbonisteel, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Sotaro Ikeda [:sotaro]]

I could also reproduce the problem on Ubuntu 18.04 and on Ubuntu 19.04. When the titlebar was toggled, nsWindow::HideWaylandWindow() was called and CompositorSession was re-created. It caused the problem. To address the problem, WebRenderBridgeChild in child process needs to be re-created for new root WebRenderBridgeParent, since WebRenderBridgeParent::UpdateWebRender() does not work for this use case.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1584511 - Backout

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c5c11d15147
Handle Compositor session recreation when egl_window is re-created r=stransky

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5c5c11d15147

Comment 6

[Sotaro Ikeda [:sotaro]]

The patch had 2 problems.

• nsWindow::HideWaylandWindow() is called just during closing a window.
• GPUProcessManager::Get()->ResetCompositors() updates all compositor. But it does not set "mCompositorInitiallyPaused = true" to all widget.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00e66d88797b
Backout r=stransky

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/00e66d88797b

Comment 9

[Sotaro Ikeda [:sotaro]]

On latest nightly, toggling titlebar does not work by Bug 1596709.

Comment 10

[Sotaro Ikeda [:sotaro]]

Bug 1542808 seemed to make the symptom worse.

Comment 11

[Sotaro Ikeda [:sotaro]]

The problem was addressed in latest nightly for me.

Comment 12

[Kestrel]

It is working for me as well and also with widget.wayland_vsync.enabled = true.

Fix range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4d9adeb56c3217b5082d6420e5e80af92072b737&tochange=f0d5103d83e9598e54addb2bdfd22dc2cc019d69

Fixed by Bug 1597861.

Comment 13

[Sotaro Ikeda [:sotaro]]

Great, thank you!