1584545 - Autocomplete and default action are different

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Verdi [:verdi] Best to slack me]

Attachment: Screen Shot 2019-09-27 at 8.57.09 AM.png

I have a bookmark for my blog - https://michaelverdi.com/blog - and it's tagged with "blog." I was trying to go to the Mozilla blog and I typed "blog" into the address bar and it autocompleted to blog.mozilla.org but the first result (the default action) was my blog. So when I hit enter I was surprised to end up on my blog instead of the Mozilla blog.

My first thought is that we just shouldn't autocomplete in this situation.

Comment 1

[Marco Bonardo [:mak]]

The problem is the autofillPlaceholder we use to avoid flicker, we autofill on input, without knowing if the first result should be autofilled, and then we don't check back, when we actually receive it.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1584545 - Clear the autofill placeholder if the first result is not an autofill one. r=Standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b13503a2ce5f
Clear the autofill placeholder if the first result is not an autofill one. r=Standard8

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b13503a2ce5f