1584614 - Remove source code for the Provider for Google Calendar

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

The code for the Provider for Google Calendar has been moved to https://github.com/kewisch/gdata-provider/. This bug is about removing the code from comm-central.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Changes minus removals - v1

I'm not going to torture you with the full patch file. It was about 8k lines, most of which were just removed files. Aside from the changes in this patch I removed:

calendar/locales/en-US/chrome/calendar/providers/gdata/
calendar/providers/gdata/
calendar/test/unit/test_gdata_provider.js

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9097011 [details] [diff] [review]
Changes minus removals - v1

r+, but please also remove these references to avoid breaking the build.

https://searchfox.org/comm-central/search?q=gdata&case=false&regexp=false&path=taskcluster

Edit: stupid lack of formatting.

Comment 3

[Jorg K (CEST = GMT+2)]

Hi Philipp, please let me know how to land this after comment #2 as addressed. You want to push it together with bug 1579020 including the actual removals?

Comment 4

[Geoff Lankow (:darktrojan)]

I just noticed there's also a line in mail/testsuite-targets.mk which will need removing.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Additional Changes for reference

Here are the additional changes. Not sure why I didn't see the mail/ and taskcluster/ references. Uploading this FYI, will upload a complete patch in a sec.

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Full patch - v2

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Hey Jörg, I've attached a full patch in v2. Let me know if you want a try run before it goes into the tree.

Comment 8

[Jorg K (CEST = GMT+2)]

I'll handle it from here, thanks. Note the last minute change we did in bug 1563003 and also some changes we didn't do, bug 1584122 comment #2 and bug 1584648 comment #4.

Comment 9

[Jorg K (CEST = GMT+2)]

The patch needed a rebase after bug 1563003. Better safe than sorry, so I did a try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=46cd448775ec19333736cd0a68959bab3f4797f9

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d58d9fbdca01
Remove source code for the Provider for Google Calendar. r=darktrojan

Comment 11

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/comm-esr68/rev/d05d4d87d25c5d290afeb0353f218dbb7b735bf2

Comment 12

[Fabian Rodriguez:MagicFab]

The Debian changelog entry indicates " The removal of this Add-On from the Thunderbird source was discussed within
this issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1584614" - can someone please elaborate here ?

Comment 13

[Magnus Melin [:mkmelin]]

Not sure what you're asking. It was a personal add-on that for historical reasons lived in the comm-central source tree. The add-on still exists, but is now on github instead. So basically nothing changed, just where the code for the add-on can be found.