Closed Bug 1584614 Opened 6 months ago Closed 6 months ago

Remove source code for the Provider for Google Calendar

Categories

(Calendar :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(1 file, 2 obsolete files)

The code for the Provider for Google Calendar has been moved to https://github.com/kewisch/gdata-provider/. This bug is about removing the code from comm-central.

Attached patch Changes minus removals - v1 (obsolete) β€” β€” Splinter Review

I'm not going to torture you with the full patch file. It was about 8k lines, most of which were just removed files. Aside from the changes in this patch I removed:

calendar/locales/en-US/chrome/calendar/providers/gdata/
calendar/providers/gdata/
calendar/test/unit/test_gdata_provider.js

Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #9097011 - Flags: review?(geoff)
Comment on attachment 9097011 [details] [diff] [review]
Changes minus removals - v1

r+, but please also remove these references to avoid breaking the build.

https://searchfox.org/comm-central/search?q=gdata&case=false&regexp=false&path=taskcluster

Edit: stupid lack of formatting.
Attachment #9097011 - Flags: review?(geoff) → review+

Hi Philipp, please let me know how to land this after comment #2 as addressed. You want to push it together with bug 1579020 including the actual removals?

I just noticed there's also a line in mail/testsuite-targets.mk which will need removing.

Attached patch Additional Changes for reference (obsolete) β€” β€” Splinter Review

Here are the additional changes. Not sure why I didn't see the mail/ and taskcluster/ references. Uploading this FYI, will upload a complete patch in a sec.

Attached patch Full patch - v2 β€” β€” Splinter Review
Attachment #9097011 - Attachment is obsolete: true
Attachment #9099088 - Attachment is obsolete: true
Attachment #9099089 - Flags: review+

Hey JΓΆrg, I've attached a full patch in v2. Let me know if you want a try run before it goes into the tree.

I'll handle it from here, thanks. Note the last minute change we did in bug 1563003 and also some changes we didn't do, bug 1584122 comment #2 and bug 1584648 comment #4.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d58d9fbdca01
Remove source code for the Provider for Google Calendar. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 71

The Debian changelog entry indicates " The removal of this Add-On from the Thunderbird source was discussed within
this issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1584614" - can someone please elaborate here ?

Not sure what you're asking. It was a personal add-on that for historical reasons lived in the comm-central source tree. The add-on still exists, but is now on github instead. So basically nothing changed, just where the code for the add-on can be found.

You need to log in before you can comment on or make changes to this bug.