1584795 - about:config (config editor) search box missing context menu in TB 68 and trunk

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[Jorg K (CEST = GMT+2)]

Another one for you, Magnus?

Comment 1

[Alessandro Castellani [:aleca]]

I tried to take a look at this.
The config.xul file comes from m-c, so we can't edit it directly to add the JS scripts we need to enable the context menu.
The context menu works on Firefox because this file is opened in a Tab and not a Dialog like we're doing. At least, I think this might be the reason.

I tried to load the missing scripts with Services.scriptloader.loadSubScript() on dialog opening, which made the context menu appear, but it's unfortunately broken as none of the menu items work.

Probably it's an easy solution and I'm just not that smart.

Comment 2

[Richard Marti (:Paenglab)]

Firefox uses the HTML version of about:config in browser/components/aboutconfig/content. A change in the old files doesn't affect FX.

Comment 3

[Jorg K (CEST = GMT+2)]

I tried to load the missing scripts with Services.scriptloader.loadSubScript() on dialog opening,
which made the context menu appear, but it's unfortunately broken as none of the menu items work.

Thanks for taking a look. That's a start. Please get into the habit of posting WIP patches, to others might get inspired, or at least to document what works and what doesn't.

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: 1584795-config-editor-WIP

This is the WIP patch.
As you can see I tried to load the script from the subdialogs.js file, in order to prevent further issues of missing context menus in other submenu.

I really doubt this is the correct approach to fix this.

Comment 5

[Magnus Melin [:mkmelin]]

You should just make a patch to fix it in m-c. I.e. add the scripts to toolkit/components/viewconfig/content/config.xul

Comment 6

[Jorg K (CEST = GMT+2)]

I'll do it.

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: Bug 1584795 - Add editMenuOverlay.js and globalOverlay.js to config.xul to fix context menu for Thunderbird.

These are needed for TB where about:config is loaded into a subdialogue. They don't seem to be needed for FF.

Comment 8

[:Gijs (he/him)]

Is this a regression? When did things break / regress?

Comment 9

[Jorg K (CEST = GMT+2)]

Sorry if this isn't clear. For all I know, the context menu for the search box in about:config is working in FF. It is not working in TB, and yes, this is a regression.

If you're interested when it broke in TB, we need to ask Alice to find it for us.

Comment 10

[Alice0775 White]

Regresson window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=0578849d7c953f13f6b8c6c57c1054b5a445c317&tochange=55a635377bed6cdeb57175d7e25a67b34dfce540
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a42caa9f04fc41044437ac56eab6f6086c841d9f&tochange=2abcefb31ba7b2a1c573edc5695b772826c6a078

Comment 11

[Jorg K (CEST = GMT+2)]

Attachment: 1584795.patch

Carrying over Brian's (bgrins) r+ from Phab.

Comment 12

[Jorg K (CEST = GMT+2)]

Dear sheriff, can you please land the attached patch which is the same as in Phab. I can't land it myself due to bug 1576146.

Please import the patch with
hg qimport bz:1584795
or
hg qimport https://bugzilla.mozilla.org/attachment.cgi?id=9098595 -n 1584795.patch
to avoid changing the author.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ae524d3514d
Add editMenuOverlay.js and globalOverlay.js to config.xul to fix context menu for Thunderbird. r=bgrins

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8ae524d3514d

Comment 15

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/818d63866f0700ca3ef9cf5be5990bd128c221f0 on THUNDERBIRD_68_VERBRANCH