Stop using jsimpl for RTCRtpTransceiver and friends
Categories
(Core :: WebRTC: Signaling, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox102 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
JSImpl is only barely supported, and with the additional complexity around get/setParameters, it is probably time to do this for RTCRtpTransceiver, RTCRtpSender, and RTCRtpReceiver.
Assignee | ||
Comment 1•5 years ago
|
||
Depends on D50245
Assignee | ||
Comment 2•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ae48fb08d39e0c378b27eb1ae2a64591b7e99a7
Assignee | ||
Comment 3•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3db110c1cac45993674630496e31a1b3df9ef930
Assignee | ||
Comment 4•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f23a5bd50c69568cb5d542d3eff790e3fb7f4f1
Assignee | ||
Comment 5•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=83550ac5449298ae624f3111a0ecdd4e5ce881b6
Assignee | ||
Comment 6•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=229242aee69bf23a19d1a31911227e1808562fc5
Assignee | ||
Comment 7•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=833f4d93b2a3a1c7aab046c0019fb8d6f52c8d0c
Assignee | ||
Comment 8•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bdbaaa35cf329fab1655999f3a2cc3908f3dc5c6
Assignee | ||
Comment 9•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7eab0e43252cb98ce497cbfaaffd300b5392c813
Updated•4 years ago
|
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Comment on attachment 9103793 [details]
Bug 1616875: Use timestamps for SSRC/CSRC statistics that are consistent with JS timestamps.
Revision D50395 was moved to bug 1616875. Setting attachment 9103793 [details] to obsolete.
Assignee | ||
Comment 11•2 years ago
|
||
Assignee | ||
Comment 12•2 years ago
|
||
Comment 13•2 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/63a2716431f9 Move RTCRtpTransceiver to c++. r=mjf,emilio
Comment 14•2 years ago
|
||
Backed out for causing build bustages on RTCRtpTransceiver.cpp
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/dom/media/webrtc/jsapi/RTCRtpTransceiver.cpp:191:1: error: control reaches end of non-void function [-Werror=return-type]
Comment 15•2 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c11ccbe584a2 Move RTCRtpTransceiver to c++. r=mjf,emilio
Comment 16•2 years ago
|
||
bugherder |
Comment 17•2 years ago
|
||
Backed out for causing toolchains bustages on central.
Backout link: https://hg.mozilla.org/integration/autoland/rev/97b50e3f5c3101a97ddba74d8e82ffb1bb4b7ebd
Failure log: https://treeherder.mozilla.org/logviewer?job_id=377499511&repo=mozilla-central&lineNumber=10826
Comment 18•2 years ago
|
||
I think the issue is caused by the closed curly brace at this line:
https://hg.mozilla.org/integration/autoland/file/63a2716431f9e580cbb57eaea9f502206b0e252c/dom/media/webrtc/jsapi/RTCRtpTransceiver.cpp#l171
Delete it and issue should be resolved.
Cheers,
Marko
Assignee | ||
Comment 19•2 years ago
|
||
No, it is failing here:
Another job that only runs with --full.
Comment 20•2 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b13dc6f0dd7b Move RTCRtpTransceiver to c++. r=mjf,emilio
Comment 21•2 years ago
|
||
bugherder |
Description
•