1586109 - Stop using jsimpl for RTCRtpTransceiver and friends

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task, P2)

Description

[Byron Campen [:bwc]]

JSImpl is only barely supported, and with the additional complexity around get/setParameters, it is probably time to do this for RTCRtpTransceiver, RTCRtpSender, and RTCRtpReceiver.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1616875: Use timestamps for SSRC/CSRC statistics that are consistent with JS timestamps.

Depends on D50245

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ae48fb08d39e0c378b27eb1ae2a64591b7e99a7

Comment 3

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3db110c1cac45993674630496e31a1b3df9ef930

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f23a5bd50c69568cb5d542d3eff790e3fb7f4f1

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=83550ac5449298ae624f3111a0ecdd4e5ce881b6

Comment 6

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=229242aee69bf23a19d1a31911227e1808562fc5

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=833f4d93b2a3a1c7aab046c0019fb8d6f52c8d0c

Comment 8

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bdbaaa35cf329fab1655999f3a2cc3908f3dc5c6

Comment 9

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7eab0e43252cb98ce497cbfaaffd300b5392c813

Comment 10

[Phabricator Automation]

Comment on attachment 9103793 [details]
Bug 1616875: Use timestamps for SSRC/CSRC statistics that are consistent with JS timestamps.

Revision D50395 was moved to bug 1616875. Setting attachment 9103793 [details] to obsolete.

Comment 11

[Byron Campen [:bwc]]

Attachment: Bug 1586109: Move RTCRtpTransceiver to c++. r?mjf

Comment 12

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=259ed3a936f9a18cd088455a4910a002b6d92cd0
https://treeherder.mozilla.org/jobs?repo=try&revision=eff2de89678b814fdef5628d3b8121b267aa3af6
https://treeherder.mozilla.org/jobs?repo=try&revision=1fa86245619156b87b7a2024e35cea6feb526e69

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63a2716431f9
Move RTCRtpTransceiver to c++. r=mjf,emilio

Comment 14

[Cristian Tuns]

Backed out for causing build bustages on RTCRtpTransceiver.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/media/webrtc/jsapi/RTCRtpTransceiver.cpp:191:1: error: control reaches end of non-void function [-Werror=return-type]

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c11ccbe584a2
Move RTCRtpTransceiver to c++. r=mjf,emilio

Comment 16

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c11ccbe584a2

Comment 17

[Atila Butkovits]

Backed out for causing toolchains bustages on central.

Backout link: https://hg.mozilla.org/integration/autoland/rev/97b50e3f5c3101a97ddba74d8e82ffb1bb4b7ebd

Failure started here: https://treeherder.mozilla.org/jobs?repo=mozilla-central&selectedTaskRun=cSZKVIHaRqK5iciQwR8Asg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2Cx64%2Copt%2Cbuild-linux64-base-toolchains%2Fopt%2Cbb

Failure log: https://treeherder.mozilla.org/logviewer?job_id=377499511&repo=mozilla-central&lineNumber=10826

Comment 18

[Marko Stanković]

I think the issue is caused by the closed curly brace at this line:
https://hg.mozilla.org/integration/autoland/file/63a2716431f9e580cbb57eaea9f502206b0e252c/dom/media/webrtc/jsapi/RTCRtpTransceiver.cpp#l171

Delete it and issue should be resolved.

Cheers,
Marko

Comment 19

[Byron Campen [:bwc]]

No, it is failing here:

https://hg.mozilla.org/mozilla-central/file/c11ccbe584a2460a4ce0c936a6058cfe0788e732/dom/media/webrtc/jsapi/RTCRtpTransceiver.cpp#l192

Another job that only runs with --full.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b13dc6f0dd7b
Move RTCRtpTransceiver to c++. r=mjf,emilio

Comment 21

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/b13dc6f0dd7b