Closed Bug 1588588 Opened 9 months ago Closed 8 months ago

Stop using jsimpl/PeerConnectionObserver for RTCStatsReport

Categories

(Core :: WebRTC: Signaling, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: bwc, Assigned: bwc)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

Right now, all getStats calls (including those to individual RTCRtpReceivers/Senders) are funneled through the same monolithic getStats implementation in PeerConnectionImpl. If we move RTCRtpReceiver/RTCRtpSender from JS to C++, and have them implement the logic for getStats, we'll need to move RTCStatsReport to C++ also, and do some refactoring.

Attachment #9100963 - Attachment description: Bug 1588588: (WIP) Remove jsimpl for RTCStatsReport, and refactor to prepare for moving some stats functionality to RTCRtpReceiver/Sender. → Bug 1588588: Remove jsimpl for RTCStatsReport, and refactor to prepare for moving some stats functionality to RTCRtpReceiver/Sender. r?ng,smaug,jib

Try looks good.

Still waiting on Windows 10 x64 QuantumRender wpt.

Seems like Window 10 x64 qr wpt just aren't running, and auth on treeherder is busted so I cannot retrigger.

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/957e8453da78
Remove jsimpl for RTCStatsReport, and refactor to prepare for moving some stats functionality to RTCRtpReceiver/Sender. r=smaug,ng
https://hg.mozilla.org/integration/autoland/rev/9d58ea9c9473
Get MediaPipeline to use the new timestamp implementation, and fix a typo in how we calculate expiries for CSRC stats. r=ng
https://hg.mozilla.org/integration/autoland/rev/8eb793bb1321
Stop expecting this ChromeOnly member to be (erroneously!) exposed to JS. r=jib
https://hg.mozilla.org/integration/autoland/rev/ba56954cac5d
Make this compile when webrtc is disabled. r=ng
Regressions: 1628200
You need to log in before you can comment on or make changes to this bug.