1588588 - Stop using jsimpl/PeerConnectionObserver for RTCStatsReport

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P2)

Description

[Byron Campen [:bwc]]

Right now, all getStats calls (including those to individual RTCRtpReceivers/Senders) are funneled through the same monolithic getStats implementation in PeerConnectionImpl. If we move RTCRtpReceiver/RTCRtpSender from JS to C++, and have them implement the logic for getStats, we'll need to move RTCStatsReport to C++ also, and do some refactoring.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1588588: Remove jsimpl for RTCStatsReport, and refactor to prepare for moving some stats functionality to RTCRtpReceiver/Sender. r?ng,smaug,jib

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2df3876e546d21bd9e973cde74516958a7c73678

Comment 3

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d52e351076e71ed72ffff588d108b47e3486d86d

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=57c33e2d5c4799ee9d2a8601b743712a5117416c

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=56c39e652dd879eff8b18f848ffc445f84492cbc

Comment 6

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=540ceb3cf95fdd401f832cb3d804f19d99120c9e

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4246f55c159f39ee49799e31152b760b342d716a

Comment 8

[Byron Campen [:bwc]]

Attachment: Bug 1588588: Get MediaPipeline to use the new timestamp implementation, and fix a typo in how we calculate expiries for CSRC stats. r?ng

Depends on D49195

Comment 9

[Byron Campen [:bwc]]

Attachment: Bug 1588588: Stop expecting this ChromeOnly member to be (erroneously!) exposed to JS. r?jib

Depends on D50113

Comment 10

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9a37c299ef478cde344a966f6ec1619b0d18d6a

Comment 11

[Byron Campen [:bwc]]

Attachment: Bug 1588588: Make this compile when webrtc is disabled. r?ng

Depends on D50114

Comment 12

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=da9dd835936538287d5cb0ff619aff4f50fb65e8

Comment 13

[Byron Campen [:bwc]]

Try looks good.

Comment 14

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=09eeef7d9ef8c246f468e4b953c09aac67920d37

Comment 15

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6858ca26aebf0018e3146cacfbe89f625092b788

Comment 16

[Byron Campen [:bwc]]

Still waiting on Windows 10 x64 QuantumRender wpt.

Comment 17

[Byron Campen [:bwc]]

Seems like Window 10 x64 qr wpt just aren't running, and auth on treeherder is busted so I cannot retrigger.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/957e8453da78
Remove jsimpl for RTCStatsReport, and refactor to prepare for moving some stats functionality to RTCRtpReceiver/Sender. r=smaug,ng
https://hg.mozilla.org/integration/autoland/rev/9d58ea9c9473
Get MediaPipeline to use the new timestamp implementation, and fix a typo in how we calculate expiries for CSRC stats. r=ng
https://hg.mozilla.org/integration/autoland/rev/8eb793bb1321
Stop expecting this ChromeOnly member to be (erroneously!) exposed to JS. r=jib
https://hg.mozilla.org/integration/autoland/rev/ba56954cac5d
Make this compile when webrtc is disabled. r=ng

Comment 19

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/957e8453da78
https://hg.mozilla.org/mozilla-central/rev/9d58ea9c9473
https://hg.mozilla.org/mozilla-central/rev/8eb793bb1321
https://hg.mozilla.org/mozilla-central/rev/ba56954cac5d