1616937 - Stop using JSImpl for RTCRtpSender

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task, P2)

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1616937: Some simplifications that are possible because PeerConnectionImpl is cycle-collected. r?jib

This happens to fix a failure in webrtc/RTCPeerConnection-restartIce.https.html.

Depends on D141738

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1616937: Move RTCRtpSender to c++ r?mjf

Depends on D141740

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1616937: Remove main thread parameters/members. r?mjf

This ability to st the main thread has never been used, and in many cases is
not possible due to things being cycle collected (and therefore
main-thread-only).

Depends on D141770

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1616937: Hold strong refs to the PC in Transceiver/Sender/Receiver. r?mjf

These are cycle collected, so no need to use this weakptr stuff.

Depends on D142382

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1616937: Improve error handling during conduit updates. r?mjf

Most of the errors we check for here should never happen, so crash/assert where
appropriate. Also, handle the codec negotiation failure case outside of the
conversion function, where we can log it better.

Depends on D142383

Comment 6

[Byron Campen [:bwc]]

Attachment: Bug 1616937: Move some sender and receiver logic to RTCRtpSender/Receiver. r?mjf

Depends on D142384

Comment 7

[Byron Campen [:bwc]]

Attachment: Bug 1616937: Fix some warnings from clang-tidy on pre-existing code. r?mjf

Depends on D142385

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31d4e8adf1dc
Move RTCRtpSender to c++ r=mjf,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/41ff3e562389
Remove main thread parameters/members. r=mjf
https://hg.mozilla.org/integration/autoland/rev/f045541b2575
Hold strong refs to the PC in Transceiver/Sender/Receiver. r=mjf
https://hg.mozilla.org/integration/autoland/rev/91a1718d9a5a
Improve error handling during conduit updates. r=mjf
https://hg.mozilla.org/integration/autoland/rev/6908b674bc94
Move some sender and receiver logic to RTCRtpSender/Receiver. r=mjf
https://hg.mozilla.org/integration/autoland/rev/f853e1e31b38
Fix some warnings from clang-tidy on pre-existing code. r=mjf

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/31d4e8adf1dc
https://hg.mozilla.org/mozilla-central/rev/41ff3e562389
https://hg.mozilla.org/mozilla-central/rev/f045541b2575
https://hg.mozilla.org/mozilla-central/rev/91a1718d9a5a
https://hg.mozilla.org/mozilla-central/rev/6908b674bc94
https://hg.mozilla.org/mozilla-central/rev/f853e1e31b38