1586336 - Update textbox tests in layout/ to use input

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Brian Grinstead [:bgrins]]

Spinning this out of Bug 1566674

Comment 1

[Emma Malysz]

Attachment: Bug 1586336, Replace XUL textbox with HTML input in testcases within layout directory

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be7c53bea22d
Replace XUL textbox with HTML input in testcases within layout directory r=dholbert

Comment 3

[Raul Gurzau (:RaulG)]

Backed out changeset be7c53bea22d (bug 1586336) for reftest failures at accesskey.xul on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/86961574004badd8018688be05557509afb08982

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=be7c53bea22dc6ac2d78e573a9a014fec4383c53

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269809387&repo=autoland&lineNumber=28048

Log snippet:

[task 2019-10-04T17:14:20.054Z] 17:14:20 INFO - REFTEST TEST-START | chrome://reftest/content/xul/accesskey.xul == chrome://reftest/content/xul/accesskey-ref.xul
[task 2019-10-04T17:14:20.055Z] 17:14:20 INFO - REFTEST INFO | SET PREFERENCE pref(ui.key.menuAccessKey,18)
[task 2019-10-04T17:14:20.055Z] 17:14:20 INFO - REFTEST TEST-LOAD | chrome://reftest/content/xul/accesskey.xul | 5 / 75 (6%)
[task 2019-10-04T17:14:20.128Z] 17:14:20 INFO - ++DOMWINDOW == 17 (0x11dbca000) [pid = 1828] [serial = 19] [outer = 0x11c04a020]
[task 2019-10-04T17:14:20.136Z] 17:14:20 INFO - [Child 1828, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 3690
[task 2019-10-04T17:14:20.137Z] 17:14:20 INFO - [Child 1828, Main Thread] WARNING: '!aWin', file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 1386
[task 2019-10-04T17:14:20.137Z] 17:14:20 INFO - [Child 1828, Main Thread] WARNING: '!aWin', file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 1386
[task 2019-10-04T17:14:20.362Z] 17:14:20 INFO - REFTEST INFO | RESTORE PREFERENCE pref(ui.key.menuAccessKey,0)
[task 2019-10-04T17:14:20.362Z] 17:14:20 INFO - REFTEST INFO | SET PREFERENCE pref(ui.key.menuAccessKey,18)
[task 2019-10-04T17:14:20.362Z] 17:14:20 INFO - REFTEST TEST-LOAD | chrome://reftest/content/xul/accesskey-ref.xul | 5 / 75 (6%)
[task 2019-10-04T17:14:20.363Z] 17:14:20 INFO - ++DOMWINDOW == 18 (0x11eb4a000) [pid = 1828] [serial = 20] [outer = 0x11c04a020]
[task 2019-10-04T17:14:20.429Z] 17:14:20 INFO - [Child 1828, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 3690
[task 2019-10-04T17:14:20.506Z] 17:14:20 INFO - ++DOMWINDOW == 19 (0x11eb4e400) [pid = 1828] [serial = 21] [outer = 0x11c04a020]
[task 2019-10-04T17:14:20.511Z] 17:14:20 INFO - [Child 1828, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 217
[task 2019-10-04T17:14:20.552Z] 17:14:20 INFO - ++DOMWINDOW == 20 (0x11eb51000) [pid = 1828] [serial = 22] [outer = 0x11c04a020]
[task 2019-10-04T17:14:20.604Z] 17:14:20 INFO - REFTEST TEST-UNEXPECTED-FAIL | chrome://reftest/content/xul/accesskey.xul == chrome://reftest/content/xul/accesskey-ref.xul | image comparison, max difference: 51, number of differing pixels: 940
[

Comment 4

[Daniel Holbert [:dholbert]]

Looks like the patch just needs to do the replacements in accesskey.xul -- the patch doesn't touch that file right now. (But it does do the replacement in its reference case, and apparently <input> is a little bit taller than <textbox>, so only-changing-the-reference-case triggered a test failure.)

Comment 5

[Phabricator Automation]

Comment on attachment 9098880 [details]
Bug 1586336, Replace XUL textbox with HTML input in testcases within layout directory

Revision D48126 was moved to bug 1566674. Setting attachment 9098880 [details] to obsolete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c47c7026dac
Replace XUL textbox with HTML input in testcases within layout directory r=dholbert

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8c47c7026dac

Comment 8

[Emma Malysz]

Fix being handled in Bug 1586512